Changeset 82840 in vbox for trunk/src/VBox

Timestamp:

Jan 23, 2020 9:36:40 AM (5 years ago)

Author:

vboxsync

Message:

IPRT/FTP: Make sure to only add allowed (supported) FS entries to collections. bugref:9646

File:

• trunk/src/VBox/Runtime/generic/ftp-server.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/generic/ftp-server.cpp

@@ -1552 +1552 @@
     }
 
+    /* Anything else besides files and directores is not allowed; just don't show them at all for the moment. */
+    switch (pInfo->Attr.fMode & RTFS_TYPE_MASK)
+    {
+        case RTFS_TYPE_DIRECTORY:
+            RT_FALL_THROUGH();
+        case RTFS_TYPE_FILE:
+            break;
+
+        default:
+            return VINF_SUCCESS;
+    }
+
     /* Make sure there is space in the collection for the new entry. */
     if (pCollection->cEntries >= pCollection->cEntriesAllocated)
@@ -2282 +2294 @@
     {
         LogFlowFunc(("Handling command '%s'\n", papszArgs[0]));
+        for (uint8_t a = 0; a < cArgs; a++)
+            LogFlowFunc(("\targ[%RU8] = '%s'\n", a, papszArgs[a]));
 
         unsigned i = 0;