Changeset 82977 in vbox

Timestamp:

Feb 4, 2020 12:45:12 PM (5 years ago)

Author:

vboxsync

Message:

VMM/GMMR0: Use the chunk list rather than the AVL tree in GMMR0FindDuplicatePageReq to look for duplicate pages. This will restricts the AVL tree to lookups and make it simpler to protect. [fixes] bugref:9627

File:

• trunk/src/VBox/VMM/VMMR0/GMMR0.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR0/GMMR0.cpp

@@ -665 +665 @@
     VMCPUID                 idCpu;
 } GMMCHECKSHAREDMODULEINFO;
-
-/**
- * Argument packet for gmmR0FindDupPageInChunk by GMMR0FindDuplicatePage.
- */
-typedef struct GMMFINDDUPPAGEINFO
-{
-    PGVM                    pGVM;
-    PGMM                    pGMM;
-    uint8_t                *pSourcePage;
-    bool                    fFoundDuplicate;
-} GMMFINDDUPPAGEINFO;
 
 
@@ -5433 +5422 @@
                      * Walk the chunks
                      */
-                    GMMFINDDUPPAGEINFO Args;
-                    Args.pGVM            = pGVM;
-                    Args.pGMM            = pGMM;
-                    Args.pSourcePage     = pbSourcePage;
-                    Args.fFoundDuplicate = false;
-
-                    PGMMCHUNK pChunk;
                     pReq->fDuplicate = false;
                     RTListForEach(&pGMM->ChunkList, pChunk, GMMCHUNK, ListNode)