Changeset 82987 in vbox for trunk

Timestamp:

Feb 5, 2020 11:08:35 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

135998

Message:

DrvAudio: Using #ifdef DEBUG around logging statements almost always wrong.

File:

• trunk/src/VBox/Devices/Audio/DrvAudio.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DrvAudio.cpp

@@ -52 +52 @@
 static void drvAudioStreamFree(PPDMAUDIOSTREAM pStream);
 static int drvAudioStreamUninitInternal(PDRVAUDIO pThis, PPDMAUDIOSTREAM pStream);
-static int drvAudioStreamInitInternal(PDRVAUDIO pThis, PPDMAUDIOSTREAM pStream, PPDMAUDIOSTREAMCFG pCfgHost, PPDMAUDIOSTREAMCFG pCfgGuest);
 static int drvAudioStreamIterateInternal(PDRVAUDIO pThis, PPDMAUDIOSTREAM pStream);
 static int drvAudioStreamReInitInternal(PDRVAUDIO pThis, PPDMAUDIOSTREAM pStream);
@@ -550 +549 @@
     pCfgHost->enmLayout = PDMAUDIOSTREAMLAYOUT_NON_INTERLEAVED;
 
-#ifdef DEBUG
+#ifdef LOG_ENABLED
     LogFunc(("[%s] Requested host format:\n", pStream->szName));
     DrvAudioHlpStreamCfgPrint(pCfgHost);
@@ -570 +569 @@
         return rc;
 
-#ifdef DEBUG
+#ifdef LOG_ENABLED
     LogFunc(("[%s] Acquired host format:\n",  pStream->szName));
     DrvAudioHlpStreamCfgPrint(&CfgHostAcq);
@@ -2532 +2531 @@
     if (RT_FAILURE(rc))
     {
+        Log(("drvAudioStreamCreate: failed - %Rrc\n", rc));
         if (pStream)
         {