Changeset 82990 in vbox for trunk

Timestamp:

Feb 5, 2020 11:43:13 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

136002

Message:

VMM/GMMR0: Added TLB statistics for GMMR0PageIdToVirt. bugref:9627

Location:

trunk

Files:

• include/VBox/vmm/vm.h (modified) (1 diff)
• include/VBox/vmm/vm.mac (modified) (1 diff)
• src/VBox/VMM/VMMR0/GMMR0.cpp (modified) (1 diff)
• src/VBox/VMM/VMMR0/GMMR0Internal.h (modified) (1 diff)
• src/VBox/VMM/VMMR3/VM.cpp (modified) (1 diff)

trunk/include/VBox/vmm/vm.h

@@ -1435 +1435 @@
     } cfgm;
 
+    /** Statistics for ring-0 only components. */
+    struct
+    {
+        /** GMMR0 stats. */
+        struct
+        {
+            /** Chunk TLB hits. */
+            uint64_t    cChunkTlbHits;
+            /** Chunk TLB misses. */
+            uint64_t    cChunkTlbMisses;
+        } gmm;
+        uint64_t    au64Padding[6];     /* probably more comming here... */
+    } R0Stats;
+
     /** Padding for aligning the structure size on a page boundrary. */
-    uint8_t         abAlignment2[664 - 64 + 256 - sizeof(PVMCPUR3) * VMM_MAX_CPU_COUNT];
+    uint8_t         abAlignment2[600 - 64 + 256 - sizeof(PVMCPUR3) * VMM_MAX_CPU_COUNT];
 
     /* ---- end small stuff ---- */

trunk/include/VBox/vmm/vm.mac

@@ -137 +137 @@
     .vm                     resb 32
     .cfgm                   resb 8
+    .R0Stats                resb 64
 
-    .abAlignment2           resb 664 - 64 + 256 - RTR0PTR_CB * VMM_MAX_CPU_COUNT
+    .abAlignment2           resb 600 - 64 + 256 - RTR0PTR_CB * VMM_MAX_CPU_COUNT
 
     alignb RTR0PTR_CB * VMM_MAX_CPU_COUNT ; ASSUMES VMM_MAX_CPU_COUNT is a power of two.

trunk/src/VBox/VMM/VMMR0/GMMR0.cpp

@@ -4558 +4558 @@
         && pTlbe->idGeneration == ASMAtomicUoReadU64(&pGMM->idFreeGeneration)
         && pChunk->Core.Key    == idChunk)
-    { /* hopeful outcome */ }
+        pGVM->R0Stats.gmm.cChunkTlbHits++; /* hopefully this is a likely outcome */
     else
     {
+        pGVM->R0Stats.gmm.cChunkTlbMisses++;
+
+        /*
+         * Look it up in the chunk tree.
+         */
         RTSpinlockAcquire(pGMM->hSpinLockTree);
         pChunk = gmmR0GetChunkLocked(pGMM, idChunk);

trunk/src/VBox/VMM/VMMR0/GMMR0Internal.h

@@ -107 +107 @@
     /** Spinlock protecting the chunk lookup TLB. */
     RTSPINLOCK          hChunkTlbSpinLock;
+    uint64_t            cChunkTlbHits;
+    uint64_t            cChunkTlbMisses;
     /** The chunk lookup TLB used by GMMR0PageIdToVirt. */
     GMMPERVMCHUNKTLBE   aChunkTlbEntries[GMMPERVM_CHUNKTLB_ENTRIES];

trunk/src/VBox/VMM/VMMR3/VM.cpp

@@ -836 +836 @@
     STAM_REG(pVM, &pUVM->vm.s.StatReqPushBackRaces, STAMTYPE_COUNTER,  "/VM/Req/PushBackRaces",  STAMUNIT_OCCURENCES,        "Number of push back races.");
 
+    /* Statistics for ring-0 components: */
+    STAM_REL_REG(pVM, &pVM->R0Stats.gmm.cChunkTlbHits,   STAMTYPE_COUNTER, "/GMM/ChunkTlbHits",   STAMUNIT_OCCURENCES, "GMMR0PageIdToVirt chunk TBL hits");
+    STAM_REL_REG(pVM, &pVM->R0Stats.gmm.cChunkTlbMisses, STAMTYPE_COUNTER, "/GMM/ChunkTlbMisses", STAMUNIT_OCCURENCES, "GMMR0PageIdToVirt chunk TBL misses");
+
     /*
      * Init all R3 components, the order here might be important.