Changeset 83118 in vbox for trunk

Timestamp:

Feb 19, 2020 4:32:36 PM (5 years ago)

Author:

vboxsync

Message:

/Config.kmk: Apply VBOX_RETRY also to macOS signing. Make sure that all relevant extpack content (dylibs) is signed, otherwise Mojave and later refuse to load.

File:

• trunk/Config.kmk (modified) (5 diffs)

trunk/Config.kmk

@@ -3432 +3432 @@
   $(error VBOX_SIGNING_MODE must be either 'test' or 'release'. The value '$(VBOX_SIGNING_MODE)' is not recognized.)
  endif
+ VBOX_RETRY    ?= $(ASH) $(KBUILD_DEVTOOLS)/bin/retry.sh
  # Corp code signing client.
  VBOX_CCS_CLIENT_JAR := $(firstword $(rsort \
@@ -3474 +3475 @@
   endif
 
-  VBOX_RETRY    ?= $(ASH) $(KBUILD_DEVTOOLS)/bin/retry.sh
   VBOX_SIGNTOOL ?= $(VBOX_RETRY) "$(VBOX_PATH_SIGN_TOOLS)/signtool.exe"
   VBOX_INF2CAT  ?= $(VBOX_PATH_SELFSIGN)/inf2cat.exe
@@ -3760 +3760 @@
         $(1) \
         $(if $(2),--identifier "$(2)",)
+  endif
+
+  ## Commands for signing an the extpack dylib files after link.
+  if $(intersects darwin all 1,$(VBOX_WITH_CORP_CODE_SIGNING))
+   VBOX_SIGN_EXTPACK_DYLIB_CMDS ?= $(if $(eq $(tool_do),LINK_LIBRARY),, \
+        $(call VBOX_CCS_SIGN_CMD,binary,$(out),, \
+                $(if $(VBOX_WITH_MACOS_HARDENED_RUNTIME),-hardened_runtime)) )
+  else
+   VBOX_SIGN_EXTPACK_DYLIB_CMDS ?= $(if $(eq $(tool_do),LINK_LIBRARY),, \
+        $(VBOX_CODESIGN) \
+        --verbose=9 \
+        --force \
+        $(if-expr $(KBUILD_HOST_VERSION_MAJOR) <= 14,--digest-algorithm sha256,) \
+        $(if $(VBOX_WITH_MACOS_HARDENED_RUNTIME),$(if-expr $(KBUILD_HOST_VERSION_MAJOR) <= 16,--options 0x10000,--options runtime)) \
+        --file-list - \
+        $(if-expr defined(VBOX_TSA_URL),--timestamp="$(VBOX_TSA_URL)") \
+        $(VBOX_CERTIFICATE_SUBJECT_NAME_ARGS) \
+        $(out) )
   endif
 
@@ -6398 +6416 @@
         $(VBOX_LIB_VMM_LAZY)
  endif
+ ifeq ($(KBUILD_TARGET),darwin)
+  TEMPLATE_VBoxR3ExtPack_POST_CMDS = $(VBOX_SIGN_EXTPACK_DYLIB_CMDS)
+ endif
 
  TEMPLATE_VBoxR3ExtPackApi = For the ring-3 context extension pack modules using the Main API.
@@ -6425 +6446 @@
         $(LIB_RUNTIME) \
         $(VBOX_LIB_VMM_LAZY)
+ endif
+ ifeq ($(KBUILD_TARGET),darwin)
+  TEMPLATE_VBoxR3ExtPackApi_POST_CMDS = $(VBOX_SIGN_EXTPACK_DYLIB_CMDS)
  endif