Changeset 83198 in vbox

Timestamp:

Mar 4, 2020 10:58:40 AM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: Own thread-pool for cloud related tasks, they can take too much time and freeze local GUI tasks.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UICommon.cpp (modified) (3 diffs)
• globals/UICommon.h (modified) (2 diffs)
• manager/UIVirtualMachineItemCloud.cpp (modified) (1 diff)
• manager/chooser/UIChooserAbstractModel.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp

@@ -311 +311 @@
     , m_i3DAvailable(-1)
     , m_pThreadPool(0)
+    , m_pThreadPoolCloud(0)
     , m_pIconPool(0)
     , m_pMediumEnumerator(0)
@@ -4108 +4109 @@
             this, &UICommon::sltHandleVBoxSVCAvailabilityChange);
 
-    /* Prepare thread-pool instance: */
+    /* Prepare thread-pool instances: */
     m_pThreadPool = new UIThreadPool(3 /* worker count */, 5000 /* worker timeout */);
+    m_pThreadPoolCloud = new UIThreadPool(2 /* worker count */, 1000 /* worker timeout */);
 
     /* Load translation based on the user settings: */
@@ -4557 +4559 @@
     UIConverter::cleanup();
 
-    /* Cleanup thread-pool: */
+    /* Cleanup thread-pools: */
     delete m_pThreadPool;
     m_pThreadPool = 0;
+    delete m_pThreadPoolCloud;
+    m_pThreadPoolCloud = 0;
     /* Cleanup general icon-pool: */
     delete m_pIconPool;

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICommon.h

@@ -620 +620 @@
         /** Returns the thread-pool instance. */
         UIThreadPool *threadPool() const { return m_pThreadPool; }
+        /** Returns the thread-pool instance for cloud needs. */
+        UIThreadPool *threadPoolCloud() const { return m_pThreadPoolCloud; }
     /** @} */
 
@@ -901 +903 @@
         /** Holds the thread-pool instance. */
         UIThreadPool *m_pThreadPool;
+        /** Holds the thread-pool instance for cloud needs. */
+        UIThreadPool *m_pThreadPoolCloud;
     /** @} */
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualMachineItemCloud.cpp

@@ -287 +287 @@
     {
         m_pTask = new UITaskCloudGetInstanceInfo(m_guiCloudMachine);
-        connect(m_pTask, &UITask::sigComplete,
+        connect(uiCommon().threadPoolCloud(), &UIThreadPool::sigTaskComplete,
                 this, &UIVirtualMachineItemCloud::sltHandleGetCloudInstanceInfoDone);
-        uiCommon().threadPool()->enqueueTask(m_pTask);
+        uiCommon().threadPoolCloud()->enqueueTask(m_pTask);
     }
 }

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserAbstractModel.cpp

@@ -484 +484 @@
                                     if (pTask)
                                     {
-                                        connect(pTask, &UITask::sigComplete,
+                                        connect(uiCommon().threadPoolCloud(), &UIThreadPool::sigTaskComplete,
                                                 this, &UIChooserAbstractModel::sltHandleCloudAcquireInstancesTaskComplete);
-                                        uiCommon().threadPool()->enqueueTask(pTask);
+                                        uiCommon().threadPoolCloud()->enqueueTask(pTask);
                                     }
                                 }