Changeset 83199 in vbox

Timestamp:

Mar 4, 2020 11:59:35 AM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Chooser pane: Commit r136332 helped to reveal bug in commit r136026: Lack of type checking forced UIChooserModel to handle unrelated thread tasks as well.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp

@@ -43 +43 @@
 #include "UIMessageCenter.h"
 #include "UIModalWindowManager.h"
+#include "UITask.h"
 #include "UIVirtualBoxManagerWidget.h"
 #include "UIVirtualMachineItem.h"
@@ -711 +712 @@
 void UIChooserModel::sltHandleCloudAcquireInstancesTaskComplete(UITask *pTask)
 {
+    /* Skip unrelated tasks: */
+    if (!pTask || pTask->type() != UITask::Type_CloudAcquireInstances)
+        return;
+
     /* Call to base-class: */
     UIChooserAbstractModel::sltHandleCloudAcquireInstancesTaskComplete(pTask);