Changeset 83252 in vbox for trunk/src/VBox/Runtime/common/string

Timestamp:

Mar 10, 2020 5:29:40 PM (5 years ago)

Author:

vboxsync

Message:

IPRT/ministring.cpp: Don't crash in RTCString::endsWith() when running against an empty string.

File:

• trunk/src/VBox/Runtime/common/string/ministring.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/string/ministring.cpp

@@ -982 +982 @@
     if (l1 < l2)
         return false;
-    /** @todo r=bird: If l2 is 0, then m_psz can be NULL and we will crash. See
-     *        also handling of l2 == in startsWith. */
+
+    if (!m_psz) /* Don't crash when running against an empty string. */
+        return false;
+
+    /** @todo r=bird: See handling of l2 == in startsWith; inconsistent output (if l2 == 0, it matches anything). */
 
     size_t l = l1 - l2;