Changeset 83259 in vbox for trunk/src/VBox/Frontends

Timestamp:

Mar 11, 2020 3:18:52 PM (5 years ago)

Author:

vboxsync

Message:

FE/VBoxMange / Guest Control: Explicitly use the bit bucket if waiting for in-/output is not wanted, to provide a valid VFS handle when needed. bugref:9135

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -1147 +1147 @@
  * @return  IPRT status code.
  * @param   pProcess        Pointer to appropriate process object.
- * @param   hVfsIosDst      Where to write the data.
+ * @param   hVfsIosDst      Where to write the data. Can be the bit bucket or a (valid [std]) handle.
  * @param   uHandle         Handle where to read the data from.
  * @param   cMsTimeout      Timeout (in ms) to wait for the operation to
@@ -1186 +1186 @@
  *
  * @returns true if enabled and we successfully configured it.
- * @param   fEnabled            Whether pumping this pipe is configured.
+ * @param   fEnabled            Whether pumping this pipe is configured to std handles,
+ *                              or going to the bit bucket instead.
  * @param   enmHandle           The IPRT standard handle designation.
  * @param   pszName             The name for user messages.
@@ -1209 +1210 @@
         RTMsgWarning("Error getting %s handle: %Rrc", pszName, vrc);
     }
+    else /* If disabled, all goes to / gets fed to/from the bit bucket. */
+    {
+        RTFILE hFile;
+        int vrc = RTFileOpenBitBucket(&hFile, enmHandle == RTHANDLESTD_INPUT ? RTFILE_O_READ : RTFILE_O_WRITE);
+        if (RT_SUCCESS(vrc))
+        {
+            vrc = RTVfsIoStrmFromRTFile(hFile, 0 /* fOpen */, false /* fLeaveOpen */, phVfsIos);
+            if (RT_SUCCESS(vrc))
+                return true;
+        }
+    }
+
     return false;
 }
@@ -1524 +1537 @@
                         RTThreadYield();
                         fReadStdOut = fReadStdErr = true;
+                        /* Note: In case the user specified explicitly not wanting to wait for stdout / stderr,
+                         * the configured VFS handle goes to / will be fed from the bit bucket. */
                         break;
                     case ProcessWaitResult_Timeout: