Changeset 83295 in vbox for trunk/src/VBox/ValidationKit/tests/additions

Timestamp:

Mar 16, 2020 9:12:59 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

136462

Message:

Guest Control/Main: Added flags validation for GuestSession::fileCopy[From|To]Guest() + GuestSession::directoryCopy[From|To]Guest(), enabled testcases for it by default. ​bugref:9135

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

@@ -4390 +4390 @@
             [ tdTestCopyToFile(sDst = oTestVm.pathJoin(sScratchGst, 'dstfile')), tdTestResultFailure() ],
             [ tdTestCopyToDir( sDst = sScratchGst), tdTestResultFailure() ],
+            # Both given, but invalid flags.
+            [ tdTestCopyToFile(sSrc = sBigFileHst, sDst = sScratchGst, afFlags = [ 0x40000000] ), tdTestResultFailure() ],
+            [ tdTestCopyToDir( sSrc = sScratchEmptyDirHst, sDst = sScratchGst, afFlags = [ 0x40000000] ),
+              tdTestResultFailure() ],
         ];
-        if not self.fSkipKnownBugs:
-            atTests.extend([
-                ## @todo Apparently Main doesn't check the flags, so the first test succeeds.
-                # Both given, but invalid flags.
-                [ tdTestCopyToFile(sSrc = sBigFileHst, sDst = sScratchGst, afFlags = [ 0x40000000] ), tdTestResultFailure() ],
-                [ tdTestCopyToDir( sSrc = sScratchEmptyDirHst, sDst = sScratchGst, afFlags = [ 0x40000000] ),
-                  tdTestResultFailure() ],
-            ]);
         atTests.extend([
             # Non-existing source, but no destination:
@@ -4577 +4573 @@
             [ tdTestCopyFromFile(oSrc = oExistingFileGst), tdTestResultFailure() ],
             [ tdTestCopyFromDir( sSrc = self.oTestFiles.oManyDir.sPath), tdTestResultFailure() ],
-            ##
-            ## @todo main isn't validating flags, so these theses will succeed.
-            ##
-            ## Invalid flags:
-            #[ tdTestCopyFromFile(oSrc = oExistingFileGst, sDst = os.path.join(sScratchHst, 'somefile'), afFlags = [0x40000000]),
-            #  tdTestResultFailure() ],
-            #[ tdTestCopyFromDir( oSrc = oEmptyDirGst, sDst = os.path.join(sScratchHst, 'somedir'),  afFlags = [ 0x40000000] ),
-            #  tdTestResultFailure() ],
+            # Invalid flags:
+            [ tdTestCopyFromFile(oSrc = oExistingFileGst, sDst = os.path.join(sScratchHst, 'somefile'), afFlags = [0x40000000]),
+              tdTestResultFailure() ],
+            [ tdTestCopyFromDir( oSrc = oEmptyDirGst, sDst = os.path.join(sScratchHst, 'somedir'),  afFlags = [ 0x40000000] ),
+              tdTestResultFailure() ],
             # Non-existing sources:
             [ tdTestCopyFromFile(sSrc = oTestVm.pathJoin(self.oTestFiles.oRoot.sPath, 'no-such-file-or-directory'),