Changeset 83307 in vbox

Timestamp:

Mar 17, 2020 1:03:59 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

136480

Message:

FE/Qt: bugref:9692: Runtime UI: UIFrameBuffer: A fix for frame-buffer mouse-pointer functionality; No need to reset mouse pointer rectangle to null one since other side expects us to store it in-between requests to hide/show cursor.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIFrameBuffer.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIFrameBuffer.cpp

@@ -1302 +1302 @@
 void UIFrameBufferPrivate::sltMousePointerShapeChange()
 {
-    /* Do we have view and valid cursor position?
-     * Also, please take into account, we are not currently painting
-     * framebuffer cursor if mouse integration is supported and enabled. */
+    /* Call for a cursor area update in any case, whether we are drawing it or not: */
     if (   m_pMachineView
-        && !m_pMachineView->uisession()->isHidingHostPointer()
-        && m_pMachineView->uisession()->isValidPointerShapePresent()
-        && m_pMachineView->uisession()->isValidCursorPositionPresent()
-        && (   !m_pMachineView->uisession()->isMouseIntegrated()
-            || !m_pMachineView->uisession()->isMouseSupportsAbsolute()))
-    {
-        /* Call for a viewport update using known shape rectangle: */
+        && m_cursorRectangle.isValid())
         m_pMachineView->viewport()->update(m_cursorRectangle);
-    }
-    /* Don't forget to clear the rectangle in opposite case: */
-    else if (   m_pMachineView
-             && m_cursorRectangle.isValid())
-    {
-        /* Call for a viewport update: */
-        m_pMachineView->viewport()->update(m_cursorRectangle);
-        /* And erase the rectangle after all: */
-        m_cursorRectangle = QRect();
-    }
 }
 
@@ -1373 +1355 @@
              && m_cursorRectangle.isValid())
     {
-        /* Call for a viewport update: */
+        /* Call for a cursor area update: */
         m_pMachineView->viewport()->update(m_cursorRectangle);
-        /* And erase the rectangle after all: */
-        m_cursorRectangle = QRect();
     }
 }