Changeset 83322 in vbox for trunk/src/VBox/Main/src-client

Timestamp:

Mar 19, 2020 9:33:49 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

136515

Message:

Guest Control/Main: Resolved another @todo in GuestSessionTask::setProgressErrorMsg(): Don't use format string.

File:

• trunk/src/VBox/Main/src-client/GuestSessionImplTasks.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/GuestSessionImplTasks.cpp

@@ -208 +208 @@
         && !fCompleted)
     {
-#if 0 /* Had to quick fix this myself now that the test case triggers it. Please address properly as suggested below. */
         HRESULT hr2 = mProgress->i_notifyComplete(hr,
                                                   COM_IIDOF(IGuestSession),
                                                   GuestSession::getStaticComponentName(),
-                                                  /** @todo r=bird: i_notifyComplete takes a format string, so this is
-                                                   *        potentially risky business if a user input mentioned by the message
-                                                   *        text contains '%s'!  With code below for how to do this less
-                                                   *        painfully and with fewer string copies. */
                                                   strMsg.c_str());
-#else
-        HRESULT hr2 = mProgress->i_notifyComplete(hr,
-                                                  COM_IIDOF(IGuestSession),
-                                                  GuestSession::getStaticComponentName(),
-                                                  "%s", strMsg.c_str());
-#endif
         if (FAILED(hr2))
             return hr2;