Changeset 83352 in vbox for trunk

Timestamp:

Mar 20, 2020 3:42:09 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9623: VirtualBox Manager: Details pane: A set of details should handle enumeration signals of media which are directly related to it only; This reduces amount of spam messages unrelated to current set.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/details

Files:

• UIDetailsSet.cpp (modified) (3 diffs)
• UIDetailsSet.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsSet.cpp

@@ -26 +26 @@
 #include "UIDetailsModel.h"
 #include "UIDetailsSet.h"
+#include "UIMedium.h"
 #include "UIVirtualBoxEventHandler.h"
 #include "UIVirtualMachineItemCloud.h"
@@ -581 +582 @@
 }
 
-void UIDetailsSet::sltUpdateAppearance()
-{
+void UIDetailsSet::sltMediumEnumerated(const QUuid &uId)
+{
+    /* Is this our medium changed? */
+    const UIMedium guiMedium = uiCommon().medium(uId);
+    if (   guiMedium.isNull()
+        || !guiMedium.machineIds().contains(m_machine.GetId()))
+        return;
+
     /* Update appearance: */
     rebuildSet();
@@ -605 +612 @@
 
     /* Meidum-enumeration connections: */
-    connect(&uiCommon(), &UICommon::sigMediumEnumerationStarted, this, &UIDetailsSet::sltUpdateAppearance);
-    connect(&uiCommon(), &UICommon::sigMediumEnumerationFinished, this, &UIDetailsSet::sltUpdateAppearance);
+    connect(&uiCommon(), &UICommon::sigMediumEnumerated, this, &UIDetailsSet::sltMediumEnumerated);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsSet.h

@@ -141 +141 @@
     /** @name Item stuff.
       * @{ */
-        /** Updates item appearance. */
-        void sltUpdateAppearance();
+        /** Handles enumerated signal for medium with @a uId. */
+        void sltMediumEnumerated(const QUuid &uId);
     /** @} */