Changeset 83421 in vbox

Timestamp:

Mar 25, 2020 5:06:54 PM (5 years ago)

Author:

vboxsync

Message:

Guest Control/VBoxService: Resolved another @todo: Thread ID wrap around not needed. bugref:9320

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp

@@ -2375 +2375 @@
     /* Static counter to help tracking session thread <-> process relations. */
     static uint32_t s_uCtrlSessionThread = 0;
-#if 1
-    if (++s_uCtrlSessionThread == 100000)
-#else /* This must be some joke, right? ;-) */
-    if (s_uCtrlSessionThread++ == UINT32_MAX)
-#endif
-        s_uCtrlSessionThread = 0; /* Wrap around to not let IPRT freak out. */
 
     /*
@@ -2422 +2416 @@
             if (RT_SUCCESS(rc))
             {
+                s_uCtrlSessionThread++;
+
                 /*
                  * Start the session child process.
@@ -2432 +2428 @@
                      */
                     rc = RTThreadCreateF(&pSessionThread->Thread, vgsvcGstCtrlSessionThread, pSessionThread /*pvUser*/, 0 /*cbStack*/,
-                                         RTTHREADTYPE_DEFAULT, RTTHREADFLAGS_WAITABLE, "CtrlSess%u", s_uCtrlSessionThread);
+                                         RTTHREADTYPE_DEFAULT, RTTHREADFLAGS_WAITABLE, "gctls%RU32", s_uCtrlSessionThread);
                     if (RT_SUCCESS(rc))
                     {