Changeset 83441 in vbox

Timestamp:

Mar 26, 2020 2:38:25 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

136663

Message:

Guest Control/VBoxService: Resolved another @todo: Don't spin forever and wait a bit on error in vgsvcGstCtrlSessionSpawnWorker(). bugref:9320

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp

@@ -1743 +1743 @@
             if (pvScratchBuf)
             {
+                int cFailedMsgPeeks = 0;
+
                 /*
                  * Message processing loop.
@@ -1764 +1766 @@
                         if (fShutdown)
                             break;
+
+                        cFailedMsgPeeks = 0;
+
+                        /* Let others run (guests are often single CPU) ... */
+                        RTThreadYield();
                     }
-                    else /** @todo Shouldn't we have a plan for handling connection loss and such?  Now, we'll just spin like crazy. */
-                        VGSvcVerbose(3, "Getting host message failed with %Rrc\n", rc); /* VERR_GEN_IO_FAILURE seems to be normal if ran into timeout. */
-
-                    /* Let others run (guests are often single CPU) ... */
-                    RTThreadYield();
+                    else
+                    {
+                        VGSvcVerbose(1, "Getting host message failed with %Rrc\n", rc);
+
+                        if (cFailedMsgPeeks++ == 3)
+                            break;
+
+                        RTThreadSleep(3 * RT_MS_1SEC);
+
+                        /** @todo Shouldn't we have a plan for handling connection loss and such? */
+                    }
                 }