Changeset 83480 in vbox for trunk/src/VBox

Timestamp:

Mar 30, 2020 1:03:58 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Make sure cloud item state change signal doesn't bother global item.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManagerWidget.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManagerWidget.cpp

@@ -285 +285 @@
 void UIVirtualBoxManagerWidget::sltHandleCloudMachineStateChange(const QUuid &uId)
 {
-    /* Acquire current item: */
-    UIVirtualMachineItem *pItem = currentItem();
-    const bool fCurrentItemIsOk = pItem && pItem->accessible();
-
-    /* If current item is Ok: */
-    if (fCurrentItemIsOk)
-    {
-        /* If Error-pane is chosen currently => open tool currently chosen in Tools-pane: */
-        if (m_pPaneToolsMachine->currentTool() == UIToolType_Error)
-            sltHandleToolsPaneIndexChange();
-
-        /* If we still have same item selected: */
-        if (pItem && pItem->id() == uId)
-        {
-            /* Propagate current items to update the Details-pane: */
-            m_pPaneToolsMachine->setItems(currentItems());
-            /* Repeat the task a bit delayed: */
-            pItem->toCloud()->updateInfoAsync(true /* delayed? */);
-        }
-    }
-    else
-    {
-        /* Make sure Error pane raised: */
-        m_pPaneToolsMachine->openTool(UIToolType_Error);
-
-        /* If we still have same item selected: */
-        if (pItem && pItem->id() == uId)
-        {
-            /* Propagate current items to update the Details-pane (in any case): */
-            m_pPaneToolsMachine->setItems(currentItems());
-            /* Propagate last access error to update the Error-pane (if machine selected but inaccessible): */
-            m_pPaneToolsMachine->setErrorDetails(pItem->accessError());
-        }
-    }
-
-    /* Pass the signal further: */
-    emit sigCloudMachineStateChange(uId);
+    /* Not for global items: */
+    if (!isGlobalItemSelected())
+    {
+        /* Acquire current item: */
+        UIVirtualMachineItem *pItem = currentItem();
+        const bool fCurrentItemIsOk = pItem && pItem->accessible();
+
+        /* If current item is Ok: */
+        if (fCurrentItemIsOk)
+        {
+            /* If Error-pane is chosen currently => open tool currently chosen in Tools-pane: */
+            if (m_pPaneToolsMachine->currentTool() == UIToolType_Error)
+                sltHandleToolsPaneIndexChange();
+
+            /* If we still have same item selected: */
+            if (pItem && pItem->id() == uId)
+            {
+                /* Propagate current items to update the Details-pane: */
+                m_pPaneToolsMachine->setItems(currentItems());
+                /* Repeat the task a bit delayed: */
+                pItem->toCloud()->updateInfoAsync(true /* delayed? */);
+            }
+        }
+        else
+        {
+            /* Make sure Error pane raised: */
+            if (m_pPaneToolsMachine->currentTool() != UIToolType_Error)
+                m_pPaneToolsMachine->openTool(UIToolType_Error);
+
+            /* If we still have same item selected: */
+            if (pItem && pItem->id() == uId)
+            {
+                /* Propagate current items to update the Details-pane (in any case): */
+                m_pPaneToolsMachine->setItems(currentItems());
+                /* Propagate last access error to update the Error-pane (if machine selected but inaccessible): */
+                m_pPaneToolsMachine->setErrorDetails(pItem->accessError());
+            }
+        }
+
+        /* Pass the signal further: */
+        emit sigCloudMachineStateChange(uId);
+    }
 }