Changeset 83700 in vbox for trunk/src/VBox

Timestamp:

Apr 15, 2020 1:48:33 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Implementing inaccessible item support for UIVirtualMachineItemCloud.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualMachineItemCloud.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualMachineItemCloud.cpp

@@ -23 +23 @@
 #include "UICommon.h"
 #include "UIConverter.h"
+#include "UIErrorString.h"
 #include "UIIconPool.h"
 #include "UIMessageCenter.h"
@@ -31 +32 @@
 /* COM includes: */
 #include "CProgress.h"
+#include "CVirtualBoxErrorInfo.h"
 
 
@@ -106 +108 @@
 
     /* Now determine whether VM is accessible: */
-    m_fAccessible = /*!m_comCloudMachine.isNull()
-                  ? m_comCloudMachine.accessible()
-                  : */true;
-    m_strAccessError = /*!m_comCloudMachine.isNull()
-                     ? m_comCloudMachine.accessError()
-                     : */QString();
+    m_fAccessible = !m_comCloudMachine.isNull()
+                  ? m_comCloudMachine.GetAccessible()
+                  : true;
+    m_strAccessError =    !m_comCloudMachine.isNull()
+                       && !m_comCloudMachine.GetAccessible()
+                       && !m_comCloudMachine.GetAccessError().isNull()
+                     ? UIErrorString::formatErrorInfo(m_comCloudMachine.GetAccessError())
+                     : QString();
 
     /* Determine own VM attributes: */
-    m_strOSTypeId = !m_comCloudMachine.isNull()
+    m_strOSTypeId =    !m_comCloudMachine.isNull()
+                    && m_comCloudMachine.GetAccessible()
                   ? m_comCloudMachine.GetOSTypeId()
                   : "Other";
 
     /* Determine VM states: */
-    m_enmMachineState = !m_comCloudMachine.isNull()
+    m_enmMachineState =    !m_comCloudMachine.isNull()
+                        && m_comCloudMachine.GetAccessible()
                       ? m_comCloudMachine.GetState()
                       : KMachineState_PoweredOff;
@@ -155 +161 @@
 void UIVirtualMachineItemCloud::recachePixmap()
 {
-    /* If machine is accessible: */
-    if (m_fAccessible)
-    {
-        /* We are using icon corresponding to cached guest OS type: */
-        if (   itemType() == ItemType_CloudFake
-            && fakeCloudItemState() == FakeCloudItemState_Loading)
-            m_pixmap = uiCommon().vmGuestOSTypePixmapDefault("Cloud", &m_logicalPixmapSize);
-        else
-            m_pixmap = uiCommon().vmGuestOSTypePixmapDefault(m_strOSTypeId, &m_logicalPixmapSize);
-    }
-    /* Otherwise: */
-    else
-    {
-        /// @todo handle inaccessible cloud VM
-    }
+    /* We are using icon corresponding to cached guest OS type: */
+    if (   itemType() == ItemType_CloudFake
+        && fakeCloudItemState() == FakeCloudItemState_Loading)
+        m_pixmap = uiCommon().vmGuestOSTypePixmapDefault("Cloud", &m_logicalPixmapSize);
+    else
+        m_pixmap = uiCommon().vmGuestOSTypePixmapDefault(m_strOSTypeId, &m_logicalPixmapSize);
 }
 
@@ -227 +224 @@
 {
     /* If machine is accessible: */
-    if (m_fAccessible)
+    if (accessible())
     {
         if (itemType() == ItemType_CloudFake)