Changeset 83716 in vbox for trunk/src/VBox/Additions/darwin

Timestamp:

Apr 16, 2020 1:18:42 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

137226

Message:

darwin/VBoxClient: VBoxClient.cpp:usage() SEGVs dereferencing an uninitialized thread due to calling RTPrintf() before RTR3InitExe()

File:

• trunk/src/VBox/Additions/darwin/VBoxClient/VBoxClient.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/darwin/VBoxClient/VBoxClient.cpp

@@ -200 +200 @@
 {
     RTPrintf("usage: %s [-fvl]\n", sProgName);
-    RTPrintf("       -f\tRun in foreground (default: no)\n", sProgName);
-    RTPrintf("       -v\tIncrease verbosity level (default: no verbosity)\n", sProgName);
-    RTPrintf("       -l\tSpecify log file name (default: no log file)\n", sProgName);
+    RTPrintf("       -f\tRun in foreground (default: no)\n");
+    RTPrintf("       -v\tIncrease verbosity level (default: no verbosity)\n");
+    RTPrintf("       -l\tSpecify log file name (default: no log file)\n");
     exit(1);
 }
@@ -213 +213 @@
     bool         fDemonize     = true;
     static char *szLogFileName = NULL;
+
+    rc = RTR3InitExe(argc, &argv, 0);
+    if (RT_FAILURE(rc))
+    {
+        RTPrintf("RTR3InitExe() failed: (%Rrc)\n", rc);
+        return RTMsgInitFailure(rc);
+    }
 
     /* Parse command line */
@@ -245 +252 @@
             return 1;
         }
-    }
-
-    rc = RTR3InitExe(argc, &argv, 0);
-    if (RT_FAILURE(rc))
-    {
-        RTPrintf("RTR3InitExe() failed: (%Rrc)\n", rc);
-        return RTMsgInitFailure(rc);
     }