Changeset 83752 in vbox for trunk/src

Timestamp:

Apr 17, 2020 1:34:45 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

137273

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Implementing cloud machine power down stuff.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UIMessageCenter.cpp (modified) (1 diff)
• globals/UIMessageCenter.h (modified) (1 diff)
• manager/UIVirtualBoxManager.cpp (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.cpp

@@ -931 +931 @@
              .arg(CConsole(console).GetMachine().GetName()),
           UIErrorString::formatErrorInfo(console));
+}
+
+void UIMessageCenter::cannotPowerDownMachine(const CCloudMachine &comMachine) const
+{
+    error(0, MessageType_Error,
+          tr("Failed to stop the virtual machine <b>%1</b>.")
+             .arg(CCloudMachine(comMachine).GetName()),
+          UIErrorString::formatErrorInfo(comMachine));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIMessageCenter.h

@@ -295 +295 @@
     void cannotACPIShutdownMachine(const CConsole &console) const;
     void cannotPowerDownMachine(const CConsole &console) const;
+    void cannotPowerDownMachine(const CCloudMachine &comMachine) const;
     void cannotPowerDownMachine(const CProgress &progress, const QString &strMachineName) const;
     bool confirmStartMultipleMachines(const QString &strNames) const;

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManager.cpp

@@ -847 +847 @@
             continue;
 
-        /* For local machine: */
-        if (pItem->itemType() == UIVirtualMachineItem::ItemType_Local)
-        {
-            /* Open a session to modify VM state: */
-            CSession comSession = uiCommon().openExistingSession(pItem->id());
-            if (comSession.isNull())
-                return;
-
-            /* Get session console: */
-            CConsole comConsole = comSession.GetConsole();
-            /* Pause/resume VM: */
+        /* Open a session to modify VM state: */
+        CSession comSession = uiCommon().openExistingSession(pItem->id());
+        if (comSession.isNull())
+            return;
+
+        /* Get session console: */
+        CConsole comConsole = comSession.GetConsole();
+        /* Pause/resume VM: */
+        if (fPause)
+            comConsole.Pause();
+        else
+            comConsole.Resume();
+        if (!comConsole.isOk())
+        {
             if (fPause)
-                comConsole.Pause();
+                msgCenter().cannotPauseMachine(comConsole);
             else
-                comConsole.Resume();
-            if (!comConsole.isOk())
-            {
-                if (fPause)
-                    msgCenter().cannotPauseMachine(comConsole);
-                else
-                    msgCenter().cannotResumeMachine(comConsole);
-            }
-
-            /* Unlock machine finally: */
-            comSession.UnlockMachine();
-        }
-        /* For real cloud machine: */
-        else if (pItem->itemType() == UIVirtualMachineItem::ItemType_CloudReal)
-        {
-            if (fPause)
-                pItem->toCloud()->pause(this);
-            else
-                pItem->toCloud()->resume(this);
-        }
+                msgCenter().cannotResumeMachine(comConsole);
+        }
+
+        /* Unlock machine finally: */
+        comSession.UnlockMachine();
     }
 }
@@ -1059 +1047 @@
     foreach (UIVirtualMachineItem *pItem, itemsToPowerOff)
     {
-        /* Open a session to modify VM state: */
-        CSession comSession = uiCommon().openExistingSession(pItem->id());
-        if (comSession.isNull())
-            break;
-
-        /* Get session console: */
-        CConsole comConsole = comSession.GetConsole();
-        /* Prepare machine power down: */
-        CProgress comProgress = comConsole.PowerDown();
-        if (!comConsole.isOk())
-            msgCenter().cannotPowerDownMachine(comConsole);
-        else
-        {
-            /* Show machine power down progress: */
-            msgCenter().showModalProgressDialog(comProgress, pItem->name(), ":/progress_poweroff_90px.png");
-            if (!comProgress.isOk() || comProgress.GetResultCode() != 0)
-                msgCenter().cannotPowerDownMachine(comProgress, pItem->name());
-        }
-
-        /* Unlock machine finally: */
-        comSession.UnlockMachine();
+        /* For local machine: */
+        if (pItem->itemType() == UIVirtualMachineItem::ItemType_Local)
+        {
+            /* Open a session to modify VM state: */
+            CSession comSession = uiCommon().openExistingSession(pItem->id());
+            if (comSession.isNull())
+                break;
+
+            /* Get session console: */
+            CConsole comConsole = comSession.GetConsole();
+            /* Prepare machine power down: */
+            CProgress comProgress = comConsole.PowerDown();
+            if (!comConsole.isOk())
+                msgCenter().cannotPowerDownMachine(comConsole);
+            else
+            {
+                /* Show machine power down progress: */
+                msgCenter().showModalProgressDialog(comProgress, pItem->name(), ":/progress_poweroff_90px.png");
+                if (!comProgress.isOk() || comProgress.GetResultCode() != 0)
+                    msgCenter().cannotPowerDownMachine(comProgress, pItem->name());
+            }
+
+            /* Unlock machine finally: */
+            comSession.UnlockMachine();
+        }
+        /* For real cloud machine: */
+        else if (pItem->itemType() == UIVirtualMachineItem::ItemType_CloudReal)
+        {
+            /* Acquire cloud machine: */
+            CCloudMachine comCloudMachine = pItem->toCloud()->machine();
+            /* Prepare machine power down: */
+            CProgress comProgress = comCloudMachine.PowerDown();
+            if (!comCloudMachine.isOk())
+                msgCenter().cannotPowerDownMachine(comCloudMachine);
+            else
+            {
+                /* Show machine power down progress: */
+                msgCenter().showModalProgressDialog(comProgress, pItem->name(), ":/progress_poweroff_90px.png");
+                if (!comProgress.isOk() || comProgress.GetResultCode() != 0)
+                    msgCenter().cannotPowerDownMachine(comProgress, pItem->name());
+                /* Update info in any case: */
+                pItem->toCloud()->updateInfoAsync(false /* delayed? */);
+            }
+        }
     }
 }
@@ -1992 +2003 @@
         case UIActionIndexST_M_Machine_T_Pause:
         {
-            return isAtLeastOneItemStarted(items);
+            return isItemsLocal(items) &&
+                   isAtLeastOneItemStarted(items);
         }
         case UIActionIndexST_M_Group_S_Reset:
@@ -2024 +2036 @@
         case UIActionIndexST_M_Machine_M_Close:
         {
-            return isItemsLocal(items) &&
-                   isAtLeastOneItemStarted(items);
+            return isAtLeastOneItemStarted(items);
         }
         case UIActionIndexST_M_Group_M_Close_S_Detach:
@@ -2049 +2060 @@
         case UIActionIndexST_M_Machine_M_Close_S_PowerOff:
         {
-            return isItemsLocal(items) &&
-                   isActionEnabled(UIActionIndexST_M_Machine_M_Close, items);
+            return isActionEnabled(UIActionIndexST_M_Machine_M_Close, items);
         }
         default: