Changeset 83797 in vbox

Timestamp:

Apr 18, 2020 1:52:37 PM (5 years ago)

Author:

vboxsync

Message:

VBoxAutostart: VC++ 14.1 adjustments. Removed some unnecessary stdc++ headers and eliminated one silly std::string usage. bugref:8489

Location:

trunk/src/VBox/Frontends/VBoxAutostart

Files:

• VBoxAutostart-posix.cpp (modified) (3 diffs)
• VBoxAutostart-win.cpp (modified) (2 diffs)
• VBoxAutostartStop.cpp (modified) (1 diff)
• VBoxAutostartUtils.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxAutostart/VBoxAutostart-posix.cpp

@@ -53 +53 @@
 #include <iprt/dir.h>
 
-#include <algorithm>
-#include <list>
-#include <string>
 #include <signal.h>
 
@@ -268 +265 @@
 
     RTStrmPrintf(g_pStdErr,
-                 "Usage:\n"
-                 " %s [-v|--verbose] [-h|-?|--help]\n"
-                 " [-F|--logfile=<file>] [-R|--logrotate=<num>] [-S|--logsize=<bytes>]\n"
-                 " [-I|--loginterval=<seconds>]\n"
-                 " [-c|--config=<config file>]\n", pszImage);
-
-    RTStrmPrintf(g_pStdErr, "\n"
+                 "Usage: %s [-v|--verbose] [-h|-?|--help]\n"
+                 "           [-F|--logfile=<file>] [-R|--logrotate=<num>]\n"
+                 "           [-S|--logsize=<bytes>] [-I|--loginterval=<seconds>]\n"
+                 "           [-c|--config=<config file>]\n",
+                 pszImage);
+
+    RTStrmPrintf(g_pStdErr,
+                 "\n"
                  "Options:\n");
-
-    for (unsigned i = 0;
-         i < RT_ELEMENTS(g_aOptions);
-         ++i)
-    {
-        std::string str(g_aOptions[i].pszLong);
+    for (unsigned i = 0; i < RT_ELEMENTS(g_aOptions); i++)
+    {
+        char szOptions[128];
+        const char *pszOptions = g_aOptions[i].pszLong;
         if (g_aOptions[i].iShort < 1000) /* Don't show short options which are defined by an ID! */
         {
-            str += ", -";
-            str += g_aOptions[i].iShort;
-        }
-        str += ":";
+            RTStrPrintf(szOptions, sizeof(szOptions), "%s, -%c", g_aOptions[i].pszLong, g_aOptions[i].iShort);
+            pszOptions = szOptions;
+        }
 
         const char *pcszDescr = "";
-
         switch (g_aOptions[i].iShort)
         {
@@ -324 +318 @@
         }
 
-        RTStrmPrintf(g_pStdErr, "%-23s%s\n", str.c_str(), pcszDescr);
+        RTStrmPrintf(g_pStdErr, "%-23s%s\n", pszOptions, pcszDescr);
     }
 

trunk/src/VBox/Frontends/VBoxAutostart/VBoxAutostart-win.cpp

@@ -835 +835 @@
         com::Utf8Str sDomain;
         com::Utf8Str sUserTmp;
-        int rc = autostartGetDomainAndUser(pNode->pszKey, sDomain, sUserTmp);
+        rc = autostartGetDomainAndUser(pNode->pszKey, sDomain, sUserTmp);
         if (RT_FAILURE(rc))
             continue;
@@ -875 +875 @@
     }
 
-    RTEXITCODE ec = autostartStartMain(pCfgAstUser);
+    RTEXITCODE rcExit = autostartStartMain(pCfgAstUser);
     autostartConfigAstDestroy(pCfgAst);
-    if (ec != RTEXITCODE_SUCCESS)
+    if (rcExit != RTEXITCODE_SUCCESS)
         autostartSvcLogError("Starting VMs failed\n");
 
-    return ec;
+    return rcExit;
 }
 

trunk/src/VBox/Frontends/VBoxAutostart/VBoxAutostartStop.cpp

@@ -29 +29 @@
 #include <iprt/message.h>
 
-#include <algorithm>
 #include <list>
-#include <string>
 
 #include "VBoxAutostart.h"

trunk/src/VBox/Frontends/VBoxAutostart/VBoxAutostartUtils.cpp

@@ -30 +30 @@
 #include <iprt/stream.h>
 #include <iprt/log.h>
-#include <iprt/path.h>
-
-#include <algorithm>
-#include <list>
-#include <string>
+#include <iprt/path.h>      /* RTPATH_MAX */
 
 #include "VBoxAutostart.h"