Changeset 83808 in vbox for trunk/src/VBox/Installer/win/StubBld

Timestamp:

Apr 18, 2020 11:30:59 PM (5 years ago)

Author:

vboxsync

Message:

VBoxStub[Bld]: VC++ 14.1 warnings and some cleaning up. bugref:8489

File:

• trunk/src/VBox/Installer/win/StubBld/VBoxStubBld.cpp (modified) (13 diffs)

trunk/src/VBox/Installer/win/StubBld/VBoxStubBld.cpp

@@ -25 +25 @@
 
 #include <VBox/version.h>
+#include <iprt/types.h>
 
 #include "VBoxStubBld.h"
@@ -33 +34 @@
 {
     HRESULT hr = S_OK;
-    *phFile = ::CreateFile(pszFilePath, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
+    *phFile = CreateFile(pszFilePath, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
     if (INVALID_HANDLE_VALUE == *phFile)
-    {
         hr = HRESULT_FROM_WIN32(GetLastError());
-    }
     else
     {
         *pdwFileSize = ::GetFileSize(*phFile, NULL);
         if (!*pdwFileSize)
-        {
-            hr = HRESULT_FROM_WIN32(GetLastError());
-        }
+            hr = HRESULT_FROM_WIN32(GetLastError());
     }
     return hr;
@@ -52 +49 @@
                        DWORD dwFileSize,
                        HANDLE hResourceUpdate,
-                       const char *szResourceType,
-                       const char *szResourceId)
+                       const char *pszResourceType,
+                       const char *pszResourceId)
 {
     HRESULT hr = S_OK;
-    PVOID pvFile = NULL;
-    HANDLE hMap = NULL;
-
-    hMap = ::CreateFileMapping(hFile, NULL, PAGE_READONLY, 0, 0, NULL);
-    pvFile = ::MapViewOfFile(hMap, FILE_MAP_READ, 0, 0, dwFileSize);
-    if (!::UpdateResourceA(hResourceUpdate, szResourceType, szResourceId,
-                           MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), pvFile, dwFileSize))
-    {
+
+    HANDLE hMap = CreateFileMapping(hFile, NULL, PAGE_READONLY, 0, 0, NULL);
+    PVOID pvFile = MapViewOfFile(hMap, FILE_MAP_READ, 0, 0, dwFileSize);
+    if (!UpdateResourceA(hResourceUpdate, pszResourceType, pszResourceId,
+                         MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), pvFile, dwFileSize))
         hr = HRESULT_FROM_WIN32(GetLastError());
-    }
 
     if (pvFile)
-    {
-        ::UnmapViewOfFile(pvFile);
-        pvFile = NULL;
-    }
+        UnmapViewOfFile(pvFile);
 
     if (hMap)
-    {
-        ::CloseHandle(hMap);
-        hMap = NULL;
-    }
+        CloseHandle(hMap);
 
     return hr;
 }
 
-HRESULT IntegrateFile (HANDLE hResourceUpdate,
-                       const char* szResourceType,
-                       const char* szResourceId,
-                       const char* pszFilePath)
-{
-    HRESULT hr = S_OK;
+static HRESULT IntegrateFile(HANDLE hResourceUpdate, const char *pszResourceType,
+                             const char *pszResourceId, const char *pszFilePath)
+{
     HANDLE hFile = INVALID_HANDLE_VALUE;
     DWORD dwFileSize = 0;
-
-    do
-    {
-        hr = GetFile(pszFilePath, &hFile, &dwFileSize);
+    HRESULT hr = GetFile(pszFilePath, &hFile, &dwFileSize);
+    if (SUCCEEDED(hr))
+    {
+        hr = UpdateResource(hFile, dwFileSize, hResourceUpdate, pszResourceType, pszResourceId);
         if (FAILED(hr))
-        {
-            hr = HRESULT_FROM_WIN32(GetLastError());
-            break;
-        }
-        else
-        {
-            hr = UpdateResource(hFile, dwFileSize, hResourceUpdate, szResourceType, szResourceId);
-            if (FAILED(hr))
-            {
-                printf("ERROR: Error updating resource for file %s!", pszFilePath);
-                break;
-            }
-        }
-
-    } while (0);
-
-
-    if (INVALID_HANDLE_VALUE != hFile)
-    {
-        ::CloseHandle(hFile);
-        hFile = INVALID_HANDLE_VALUE;
-    }
-
+            printf("ERROR: Error updating resource for file %s!", pszFilePath);
+    }
+    else
+        hr = HRESULT_FROM_WIN32(GetLastError());
+
+    if (hFile != INVALID_HANDLE_VALUE)
+        CloseHandle(hFile);
     return hr;
 }
 
-static char * MyPathFilename(const char *pszPath)
-{
-    const char *psz = pszPath;
+static char *MyPathFilename(const char *pszPath)
+{
     const char *pszName = pszPath;
-
-    for (;; psz++)
+    for (const char *psz = pszPath;; psz++)
     {
         switch (*psz)
@@ -152 +118 @@
 
 
-int main (int argc, char* argv[])
+int main(int argc, char* argv[])
 {
     HRESULT hr = S_OK;
-    int rc = 0;
+    int rcExit = RTEXITCODE_SUCCESS;
 
     char szSetupStub[_MAX_PATH] = {"VBoxStub.exe"};
@@ -161 +127 @@
     HANDLE hUpdate = NULL;
 
-    do
+    do /* goto avoidance "loop" */
     {
         printf(VBOX_PRODUCT " Stub Builder v%d.%d.%d.%d\n",
@@ -180 +146 @@
         for (int i=1; i<argc; i++)
         {
-            if (0 == stricmp(argv[i], "-out") && argc > i+1)
-            {
-                hr = ::StringCchCopy(szOutput, _MAX_PATH, argv[i+1]);
-                i++;
-            }
-
-            else if (0 == stricmp(argv[i], "-stub") && argc > i+1)
-            {
-                hr = ::StringCchCopy(szSetupStub, _MAX_PATH, argv[i+1]);
-                i++;
-            }
-
-            else if (0 == stricmp(argv[i], "-target-all") && argc > i+1)
-            {
-                hr = ::StringCchCopy(stbBuildPkg[stbHeader.byCntPkgs].szSourcePath, _MAX_PATH, argv[i+1]);
+            if (!stricmp(argv[i], "-out") && argc > i+1)
+            {
+                hr = StringCchCopy(szOutput, _MAX_PATH, argv[i+1]);
+                i++;
+            }
+
+            else if (!stricmp(argv[i], "-stub") && argc > i+1)
+            {
+                hr = StringCchCopy(szSetupStub, _MAX_PATH, argv[i+1]);
+                i++;
+            }
+
+            else if (!stricmp(argv[i], "-target-all") && argc > i+1)
+            {
+                hr = StringCchCopy(stbBuildPkg[stbHeader.byCntPkgs].szSourcePath, _MAX_PATH, argv[i+1]);
                 stbBuildPkg[stbHeader.byCntPkgs].byArch = VBOXSTUBPKGARCH_ALL;
                 stbHeader.byCntPkgs++;
@@ -200 +166 @@
             }
 
-            else if (0 == stricmp(argv[i], "-target-x86") && argc > i+1)
-            {
-                hr = ::StringCchCopy(stbBuildPkg[stbHeader.byCntPkgs].szSourcePath, _MAX_PATH, argv[i+1]);
+            else if (!stricmp(argv[i], "-target-x86") && argc > i+1)
+            {
+                hr = StringCchCopy(stbBuildPkg[stbHeader.byCntPkgs].szSourcePath, _MAX_PATH, argv[i+1]);
                 stbBuildPkg[stbHeader.byCntPkgs].byArch = VBOXSTUBPKGARCH_X86;
                 stbHeader.byCntPkgs++;
@@ -208 +174 @@
             }
 
-            else if (0 == stricmp(argv[i], "-target-amd64") && argc > i+1)
-            {
-                hr = ::StringCchCopy(stbBuildPkg[stbHeader.byCntPkgs].szSourcePath, _MAX_PATH, argv[i+1]);
+            else if (!stricmp(argv[i], "-target-amd64") && argc > i+1)
+            {
+                hr = StringCchCopy(stbBuildPkg[stbHeader.byCntPkgs].szSourcePath, _MAX_PATH, argv[i+1]);
                 stbBuildPkg[stbHeader.byCntPkgs].byArch = VBOXSTUBPKGARCH_AMD64;
                 stbHeader.byCntPkgs++;
@@ -218 +184 @@
             {
                 printf("ERROR: Invalid parameter: %s\n", argv[i]);
-                hr = HRESULT_FROM_WIN32(ERROR_INVALID_PARAMETER);
+                hr = E_INVALIDARG;
                 break;
             }
             if (FAILED(hr))
             {
-                printf("ERROR: StringCchCopy failed: %#x\n", hr);
+                printf("ERROR: StringCchCopy failed: %#lx\n", hr);
                 break;
             }
@@ -238 +204 @@
         printf("Stub: %s\n", szSetupStub);
         printf("Output: %s\n", szOutput);
-        printf("# Packages: %d\n", stbHeader.byCntPkgs);
-
-        if (!::CopyFile(szSetupStub, szOutput, FALSE))
-        {
-            hr = HRESULT_FROM_WIN32(GetLastError());
-            printf("ERROR: Could not create stub loader: 0x%08x\n", hr);
-            break;
-        }
-
-        hUpdate = ::BeginUpdateResource(szOutput, FALSE);
+        printf("# Packages: %u\n", stbHeader.byCntPkgs);
+
+        if (!CopyFile(szSetupStub, szOutput, FALSE))
+        {
+            hr = HRESULT_FROM_WIN32(GetLastError());
+            printf("ERROR: Could not create stub loader: %#lx\n", hr);
+            break;
+        }
+
+        hUpdate = BeginUpdateResource(szOutput, FALSE);
 
         PVBOXSTUBPKG pPackage = stbPkg;
         char szHeaderName[_MAX_PATH] = {0};
 
-        for (BYTE i=0; i<stbHeader.byCntPkgs; i++)
+        for (BYTE i = 0; i < stbHeader.byCntPkgs; i++)
         {
             printf("Integrating (Platform %d): %s\n", stbBuildPkg[i].byArch, stbBuildPkg[i].szSourcePath);
 
             /* Construct resource name. */
-            hr = ::StringCchPrintf(pPackage->szResourceName, _MAX_PATH, "BIN_%02d", i);
+            hr = StringCchPrintf(pPackage->szResourceName, _MAX_PATH, "BIN_%02d", i);
             pPackage->byArch = stbBuildPkg[i].byArch;
 
             /* Construct final name used when extracting. */
-            hr = ::StringCchCopy(pPackage->szFileName, _MAX_PATH, MyPathFilename(stbBuildPkg[i].szSourcePath));
+            hr = StringCchCopy(pPackage->szFileName, _MAX_PATH, MyPathFilename(stbBuildPkg[i].szSourcePath));
 
             /* Integrate header into binary. */
-            hr = ::StringCchPrintf(szHeaderName, _MAX_PATH, "HDR_%02d", i);
+            hr = StringCchPrintf(szHeaderName, _MAX_PATH, "HDR_%02d", i);
             hr = UpdateResource(hUpdate, RT_RCDATA, szHeaderName, MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), pPackage, sizeof(VBOXSTUBPKG));
 
@@ -271 +237 @@
             if (FAILED(hr))
             {
-                printf("ERROR: Could not integrate binary %s (%s): 0x%08x\n",
+                printf("ERROR: Could not integrate binary %s (%s): %#lx\n",
                          pPackage->szResourceName, pPackage->szFileName, hr);
-                rc = 1;
+                rcExit = RTEXITCODE_FAILURE;
             }
 
@@ -282 +248 @@
             break;
 
-        if (!::UpdateResource(hUpdate, RT_RCDATA, "MANIFEST", MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), &stbHeader, sizeof(VBOXSTUBPKGHEADER)))
-        {
-            hr = HRESULT_FROM_WIN32(GetLastError());
-            break;
-        }
-
-        if (!::EndUpdateResource(hUpdate, FALSE))
+        if (!UpdateResource(hUpdate, RT_RCDATA, "MANIFEST", MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), &stbHeader, sizeof(VBOXSTUBPKGHEADER)))
+        {
+            hr = HRESULT_FROM_WIN32(GetLastError());
+            break;
+        }
+
+        if (!EndUpdateResource(hUpdate, FALSE))
         {
             hr = HRESULT_FROM_WIN32(GetLastError());
@@ -302 +268 @@
     if (FAILED(hr))
     {
-        printf("ERROR: Building failed! Last error: %d\n", GetLastError());
-        rc = 1;
-    }
-    return rc;
-}
+        printf("ERROR: Building failed! Last error: %lu\n", GetLastError());
+        rcExit = RTEXITCODE_FAILURE;
+    }
+    return rcExit;
+}