Changeset 83820 in vbox

Timestamp:

Apr 19, 2020 1:08:36 AM (5 years ago)

Author:

vboxsync

Message:

Main: VC++ 14.1 adjustments and warnings. bugref:8489

Location:

trunk/src/VBox/Main

Files:

• Makefile.kmk (modified) (1 diff)
• cbinding/tstCAPIGlue.c (modified) (9 diffs)
• src-all/win/VBoxProxyStub.c (modified) (2 diffs)
• src-helper-apps/VBoxExtPackHelperApp.cpp (modified) (1 diff)
• testcase/msiDarwinDescriptorDecoder.cpp (modified) (2 diffs)
• testcase/tstVBoxAPIWin.cpp (modified) (8 diffs)

trunk/src/VBox/Main/Makefile.kmk

@@ -1309 +1309 @@
  DLLS += VBoxProxyStub
  VBoxProxyStub_TEMPLATE = VBOXMAINCOMP
- VBoxProxyStub_DEFS     = REGISTER_PROXY_DLL PROXY_CLSID_IS="$(VBOX_MIDL_PROXY_CLSID_IS)" \
-        $(if $(VBOX_WITH_SDS),VBOX_WITH_SDS,)\
-        $(if $(VBOX_WITH_SDS_CLIENT_WATCHER),VBOX_WITH_SDS_CLIENT_WATCHER,)
+ ifdef VBOX_WITH_AUTOMATIC_DEFS_QUOTING
+  VBoxProxyStub_DEFS   := REGISTER_PROXY_DLL PROXY_CLSID_IS=$(quote $(VBOX_MIDL_PROXY_CLSID_IS))
+ else
+  VBoxProxyStub_DEFS   := REGISTER_PROXY_DLL PROXY_CLSID_IS="$(VBOX_MIDL_PROXY_CLSID_IS)"
+ endif
+ ifdef VBOX_WITH_SDS
+  VBoxProxyStub_DEFS   += VBOX_WITH_SDS
+ endif
+ ifdef VBOX_WITH_SDS_CLIENT_WATCHER
+  VBoxProxyStub_DEFS   +=  VBOX_WITH_SDS_CLIENT_WATCHER,)
+ endif
  VBoxProxyStub_DEFS.win.x86 = WIN32
  VBoxProxyStub_SDKS     = VBOX_NTDLL

trunk/src/VBox/Main/cbinding/tstCAPIGlue.c

@@ -137 +137 @@
     if (FAILED(rc))
     {
-        printf("cannot get event type, rc=%#x\n", rc);
+        printf("cannot get event type, rc=%#lx\n", rc);
         return S_OK;
     }
@@ -162 +162 @@
             if (FAILED(rc))
             {
-                printf("cannot get StateChangedEvent interface, rc=%#x\n", rc);
+                printf("cannot get StateChangedEvent interface, rc=%#lx\n", rc);
                 return S_OK;
             }
@@ -172 +172 @@
             rc = IStateChangedEvent_get_State(ev, &state);
             if (FAILED(rc))
-                printf("warning: cannot get state, rc=%#x\n", rc);
+                printf("warning: cannot get state, rc=%#lx\n", rc);
             IStateChangedEvent_Release(ev);
             printf("OnStateChanged: %s\n", GetStateName(state));
@@ -621 +621 @@
                         if (FAILED(rc))
                         {
-                            printf("Failed getting event: %#x\n", rc);
+                            printf("Failed getting event: %#lx\n", rc);
                             g_fStop = 1;
                             continue;
@@ -631 +631 @@
                         if (FAILED(rc))
                         {
-                            printf("Failed processing event: %#x\n", rc);
+                            printf("Failed processing event: %#lx\n", rc);
                             g_fStop = 1;
                             /* finish processing the event */
@@ -638 +638 @@
                         if (FAILED(rc))
                         {
-                            printf("Failed to mark event as processed: %#x\n", rc);
+                            printf("Failed to mark event as processed: %#lx\n", rc);
                             g_fStop = 1;
                             /* continue with event release */
@@ -771 +771 @@
             char *group;
             g_pVBoxFuncs->pfnUtf16ToUtf8(groups[i], &group);
-            printf("Groups[%d]: %s\n", i, group);
+            printf("Groups[%lu]: %s\n", i, group);
             g_pVBoxFuncs->pfnUtf8Free(group);
         }
@@ -933 +933 @@
 
                 IMachine_get_MemorySize(machine, &memorySize);
-                printf("\tMemory size: %uMB\n", memorySize);
+                printf("\tMemory size: %luMB\n", memorySize);
             }
 
@@ -1061 +1061 @@
     rc = IVirtualBox_get_Revision(vbox, &revision);
     if (SUCCEEDED(rc))
-        printf("\tRevision: %u\n", revision);
+        printf("\tRevision: %lu\n", revision);
     else
         PrintErrorInfo(argv[0], "GetRevision() failed", rc);

trunk/src/VBox/Main/src-all/win/VBoxProxyStub.c

@@ -2113 +2113 @@
          */
         HKEY hkeyTypeLibs;
-        LRESULT rc;
+        LSTATUS rc;
         rc = RegOpenKeyExW(pState->aAltDeletes[iAlt].hkeyClasses, L"TypeLib", 0 /*fOptions*/, pState->fSamDelete, &hkeyTypeLibs);
         if (rc == ERROR_SUCCESS)
@@ -2124 +2124 @@
             {
                 HKEY hkeyTypeLibId;
-                LONG rc = RegOpenKeyExW(hkeyTypeLibs, g_apwszTypeLibIds[iTlb], 0 /*fOptions*/, pState->fSamDelete, &hkeyTypeLibId);
+                rc = RegOpenKeyExW(hkeyTypeLibs, g_apwszTypeLibIds[iTlb], 0 /*fOptions*/, pState->fSamDelete, &hkeyTypeLibId);
                 if (rc == ERROR_SUCCESS)
                 {

trunk/src/VBox/Main/src-helper-apps/VBoxExtPackHelperApp.cpp

@@ -1344 +1344 @@
                                 break;
                             }
-                            MSG Msg;
                             while (PeekMessageW(&Msg, NULL, 0, 0, PM_REMOVE))
                             {

trunk/src/VBox/Main/testcase/msiDarwinDescriptorDecoder.cpp

@@ -54 +54 @@
                     " ->     FeatureId=%ls\n"
                     " -> ComponentCode=%ls\n"
-                    " ->  offArguments=%#x (%d)\n"
+                    " ->  offArguments=%#lx (%ld)\n"
                     , iArg, papwszArgs[iArg], wszProductCode, wszFeatureId, wszComponentCode, offArguments, offArguments);
         }
@@ -61 +61 @@
             fprintf(stderr,
                     "#%u: '%ls'\n"
-                    " -> error %u (%#x)\n"
+                    " -> error %lu (%#lx)\n"
                     , iArg, papwszArgs[iArg], dwErr, dwErr);
             rcExit = 1;

trunk/src/VBox/Main/testcase/tstVBoxAPIWin.cpp

@@ -117 +117 @@
 
         if (FAILED(rc))
-            printf("Error getting error info! rc = 0x%x\n", rc);
+            printf("Error getting error info! rc=%#lx\n", rc);
         else
         {
@@ -125 +125 @@
 
             if (FAILED(rc) || !errorDescription)
-                printf("Error getting error description! rc = 0x%x\n", rc);
+                printf("Error getting error description! rc=%#lx\n", rc);
             else
             {
@@ -161 +161 @@
 
         if (FAILED(rc))
-            printf("Error getting error info! rc = 0x%x\n", rc);
+            printf("Error getting error info! rc=%#lx\n", rc);
         else
         {
@@ -169 +169 @@
 
             if (FAILED(rc) || !errorDescription)
-                printf("Error getting error description! rc = 0x%x\n", rc);
+                printf("Error getting error description! rc=%#lx\n", rc);
             else
             {
@@ -193 +193 @@
             if (!SUCCEEDED(rc))
             {
-                printf("Error retrieving machine ID! rc = 0x%x\n", rc);
+                printf("Error retrieving machine ID! rc=%#lx\n", rc);
                 break;
             }
@@ -205 +205 @@
             if (!SUCCEEDED(rc))
             {
-                printf("Error creating Session instance! rc = 0x%x\n", rc);
+                printf("Error creating Session instance! rc=%#lx\n", rc);
                 break;
             }
@@ -214 +214 @@
             if (!SUCCEEDED(rc))
             {
-                printf("Could not open remote session! rc = 0x%x\n", rc);
+                printf("Could not open remote session! rc=%#lx\n", rc);
                 break;
             }
@@ -287 +287 @@
         }
         else
-            printf("Error creating VirtualBox instance! rc = 0x%x\n", rc);
+            printf("Error creating VirtualBox instance! rc=%#lx\n", rc);
     }