Changeset 84000 in vbox

Timestamp:

Apr 27, 2020 11:54:11 AM (5 years ago)

Author:

vboxsync

Message:

IPRT/xml: Simplified EIPRTFailure::EIPRTFailure, avoiding two heap allocations and letting the formatter deal with resolving status codes to strings.

File:

• trunk/src/VBox/Runtime/r3/xml.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/xml.cpp

@@ -147 +147 @@
 }
 
-EIPRTFailure::EIPRTFailure(int aRC, const char *pcszContext, ...)
-    : RuntimeError(NULL),
-      mRC(aRC)
-{
-    char *pszContext2;
-    va_list args;
-    va_start(args, pcszContext);
-    RTStrAPrintfV(&pszContext2, pcszContext, args);
-    va_end(args);
-    char *newMsg;
-    RTStrAPrintf(&newMsg, "%s: %d (%s)", pszContext2, aRC, RTErrGetShort(aRC));
-    setWhat(newMsg);
-    RTStrFree(newMsg);
-    RTStrFree(pszContext2);
+EIPRTFailure::EIPRTFailure(int aRC, const char *pszContextFmt, ...)
+    : RuntimeError(NULL)
+    , mRC(aRC)
+{
+    va_list va;
+    va_start(va, pszContextFmt);
+    m_strMsg.printfVNoThrow(pszContextFmt, va);
+    va_end(va);
+    m_strMsg.appendPrintfNoThrow(" %Rrc (%Rrs)", aRC, aRC);
 }