Changeset 84019 in vbox for trunk/src/VBox/Frontends

Timestamp:

Apr 27, 2020 4:47:43 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

137589

Message:

FE/Qt: bugref:9653: UIDetailsGenerator: Cleanup for cloud VM general info generation.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/globals/UIDetailsGenerator.cpp (modified) (6 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIDetailsGenerator.cpp

@@ -160 +160 @@
             if (!comIteratedValue.GetVisible())
                 continue;
-            /* Handle possible value type: */
+
+            /* Acquire label: */
+            const QString strLabel = comIteratedValue.GetLabel();
+
+            /* Handle possible value types: */
+            QString strValue;
             switch (comIteratedValue.GetType())
             {
@@ -167 +172 @@
                     CBooleanFormValue comValue(comIteratedValue);
                     const bool fBool = comValue.GetSelected();
-                    table << UITextTableLine(comValue.GetLabel(),
-                                             fBool ? QApplication::translate("UIDetails", "Enabled", "details (cloud value)")
-                                                   : QApplication::translate("UIDetails", "Disabled", "details (cloud value)"));
+                    strValue = fBool ? QApplication::translate("UIDetails", "Enabled", "details (cloud value)")
+                                     : QApplication::translate("UIDetails", "Disabled", "details (cloud value)");
                     break;
                 }
@@ -175 +179 @@
                 {
                     CStringFormValue comValue(comIteratedValue);
-                    table << UITextTableLine(comValue.GetLabel(), comValue.GetString());
+                    strValue = comValue.GetString();
                     break;
                 }
@@ -184 +188 @@
                     const QVector<QString> possibleValues = comValue.GetValues();
                     const int iCurrentIndex = comValue.GetSelectedIndex();
-                    table << UITextTableLine(comValue.GetLabel(), possibleValues.at(iCurrentIndex));
+                    strValue = possibleValues.value(iCurrentIndex);
                     break;
                 }
@@ -190 +194 @@
                 {
                     CRangedIntegerFormValue comValue(comIteratedValue);
-                    table << UITextTableLine(comValue.GetLabel(),
-                                             QString("%1 %2").arg(comValue.GetInteger()).arg(comValue.GetSuffix()));
+                    strValue = QString("%1 %2")
+                                   .arg(comValue.GetInteger())
+                                   .arg(QApplication::translate("UICommon", comValue.GetSuffix().toUtf8().constData()));
                     break;
                 }
@@ -197 +202 @@
                     break;
             }
+
+            /* Generate table string: */
+            table << UITextTableLine(strLabel, strValue);
         }
     }