Changeset 84030 in vbox

Timestamp:

Apr 28, 2020 9:35:19 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

137601

Message:

VBoxBugReport: %Rrf instead of RTErrGetFull + %d. Use for com failures. Use appendPrintf rather than a 2nd RTCStringFmt combining the formatted caller message with the status code. Use the RTCError(RTCString &) constructor rather than the less efficient C-string variant. bugref:9726

File:

• trunk/src/VBox/Frontends/VBoxBugReport/VBoxBugReport.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VBoxBugReport/VBoxBugReport.h

@@ -48 +48 @@
 /* Base */
 
-inline void handleRtError(int rc, const char *pszMsgFmt, ...)
+DECLINLINE(void) handleRtError(int rc, const char *pszMsgFmt, ...)
 {
     if (RT_FAILURE(rc))
@@ -54 +54 @@
         va_list va;
         va_start(va, pszMsgFmt);
-        RTCString msgArgs(pszMsgFmt, va);
+        RTCString strMsg(pszMsgFmt, va);
         va_end(va);
-        RTCStringFmt msg("%s. %s (%d)\n", msgArgs.c_str(), RTErrGetFull(rc), rc);
-        throw RTCError(msg.c_str());
+        strMsg.appendPrintfNoThrow(". %Rrf\n", rc);
+        throw RTCError(strMsg);
     }
 }
 
-inline void handleComError(HRESULT hr, const char *pszMsgFmt, ...)
+DECLINLINE(void) handleComError(HRESULT hr, const char *pszMsgFmt, ...)
 {
     if (FAILED(hr))
@@ -67 +67 @@
         va_list va;
         va_start(va, pszMsgFmt);
-        RTCString msgArgs(pszMsgFmt, va);
+        RTCString strMsg(pszMsgFmt, va);
         va_end(va);
-        RTCStringFmt msg("%s (hr=0x%x)\n", msgArgs.c_str(), hr);
-        throw RTCError(msg.c_str());
+        strMsg.appendPrintfNoThrow(". (hr=0x%x %Rhrc)\n", hr, hr);
+        throw RTCError(strMsg);
     }
 }