Changeset 84133 in vbox for trunk/src/VBox/Devices

Timestamp:

May 3, 2020 7:14:02 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

137723

Message:

AMD IOMMU: bugref:9654 Nits.

File:

• trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -540 +540 @@
         uint32_t    u16DomainId : 1;                  /**< Bits 79:64   - Domain ID. */
         uint32_t    u16GstCr3TableRootPtrMed : 16;    /**< Bits 95:80   - GCR3 TRP: Guest CR3 Table Root Pointer (Mid). */
-        uint32_t    u1IoTlbEnable : 1;                /**< Bit  96      - IOTLB Enable. */
+        uint32_t    u1IoTlbEnable : 1;                /**< Bit  96      - I: IOTLB Enable. */
         uint32_t    u1SuppressPfEvents : 1;           /**< Bit  97      - SE: Supress Page-fault events. */
         uint32_t    u1SuppressAllPfEvents : 1;        /**< Bit  98      - SA: Supress All Page-fault events. */
@@ -3426 +3426 @@
         if (uDvaExclLast - uDva >= uDvaExclFirst)
         {
-            /* Check if device access to addresses in the exclusion can be forwarded untranslated. */
+            /* Check if device access to addresses in the exclusion range can be forwarded untranslated. */
             if (    pThis->ExclRangeBaseAddr.n.u1AllowAll
                 ||  pDevTabEntry->n.u1AllowExclusion)
@@ -3458 +3458 @@
     Assert(idxSeg < RT_ELEMENTS(pThis->aDevTabBaseAddrs));
 
-    RTGCPHYS const GCPhysDevTab   = pThis->aDevTabBaseAddrs[idxSeg].n.u40Base << X86_PAGE_4K_SHIFT;
-    uint16_t const offDevTabEntry = uDevId & ~g_auDevTabSegMasks[idxSegsEn];
+    RTGCPHYS const GCPhysDevTab      = pThis->aDevTabBaseAddrs[idxSeg].n.u40Base << X86_PAGE_4K_SHIFT;
+    uint16_t const offDevTabEntry    = uDevId & ~g_auDevTabSegMasks[idxSegsEn];
     RTGCPHYS const GCPhysDevTabEntry = GCPhysDevTab + offDevTabEntry;