Changeset 84236 in vbox

Timestamp:

May 10, 2020 3:25:16 AM (5 years ago)

Author:

vboxsync

Message:

AMD IOMMU: bugref:9654 Don't forget to add the page offset into the final, translated physical address.

File:

• trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Bus/DevIommuAmd.cpp

@@ -4276 +4276 @@
                 /* Record the translated base address (before continuing to check permission bits of any subsequent pages). */
                 if (cbChecked == 0)
-                    *pGCPhysSpa = Iotlbe.GCPhysSpa;
+                {
+                    RTGCPHYS const offSpa = ~(UINT64_C(0xffffffffffffffff) << Iotlbe.cShift);
+                    *pGCPhysSpa = Iotlbe.GCPhysSpa | offSpa;
+                }
 
                 /** @todo IOMMU: Split large pages into 4K IOTLB entries and add to IOTLB cache. */
 
                 uint64_t const cbPhysPage = UINT64_C(1) << Iotlbe.cShift;
-                cbChecked += cbPhysPage;
+                cbChecked += cbPhysPage;        /** @todo IOMMU: We need to consider the offset here. */
                 if (cbChecked >= cbAccess)
                     break;