Changeset 84281 in vbox

Timestamp:

May 13, 2020 10:55:19 AM (5 years ago)

Author:

vboxsync

Message:

Devices/UartCore: Switch to the virtual sync timer for the unconnected and receive FIFO timeout as the standard virtual timer is too imprecise and causes a slow down in the OpenIndiana 2020 boot menu with multiple vCPUs enabled for example

File:

• trunk/src/VBox/Devices/Serial/UartCore.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Serial/UartCore.cpp

@@ -1501 +1501 @@
     RT_NOREF(pTimer);
 
-    PDMDevHlpCritSectEnter(pDevIns, &pThis->CritSect, VERR_IGNORED); /** @todo r=bird: You already own this crit sect, don't you?!? */
+    VBOXSTRICTRC rc1 = PDMDevHlpTimerLockClock2(pDevIns, pThis->hTimerRcvFifoTimeout, &pThis->CritSect,
+                                                VINF_SUCCESS /* must get it */);
+    AssertRCReturnVoid(VBOXSTRICTRC_VAL(rc1));
 
     if (pThis->FifoRecv.cbUsed < pThis->FifoRecv.cbItl)
@@ -1509 +1511 @@
     }
 
-    PDMDevHlpCritSectLeave(pDevIns, &pThis->CritSect);
+    PDMDevHlpTimerUnlockClock2(pDevIns, pThis->hTimerRcvFifoTimeout, &pThis->CritSect);
 }
 
@@ -1522 +1524 @@
     RT_NOREF(pTimer);
 
-    PDMDevHlpCritSectEnter(pDevIns, &pThis->CritSect, VERR_IGNORED); /** @todo r=bird: You already own this crit sect, don't you?!? */
+    VBOXSTRICTRC rc1 = PDMDevHlpTimerLockClock2(pDevIns, pThis->hTimerTxUnconnected, &pThis->CritSect,
+                                                VINF_SUCCESS /* must get it */);
+    AssertRCReturnVoid(VBOXSTRICTRC_VAL(rc1));
 
     uint8_t bVal = 0;
@@ -1570 +1574 @@
     }
 
-    PDMDevHlpCritSectLeave(pDevIns, &pThis->CritSect);
+    PDMDevHlpTimerUnlockClock2(pDevIns, pThis->hTimerTxUnconnected, &pThis->CritSect);
 }
 
@@ -2056 +2060 @@
      * Create the receive FIFO character timeout indicator timer.
      */
-    rc = PDMDevHlpTimerCreate(pDevIns, TMCLOCK_VIRTUAL, uartR3RcvFifoTimeoutTimer, pThisCC,
+    rc = PDMDevHlpTimerCreate(pDevIns, TMCLOCK_VIRTUAL_SYNC, uartR3RcvFifoTimeoutTimer, pThisCC,
                               TMTIMER_FLAGS_NO_CRIT_SECT, "UART Rcv FIFO Timer",
                               &pThis->hTimerRcvFifoTimeout);
     AssertRCReturn(rc, rc);
 
-    rc = PDMDevHlpTimerSetCritSect(pDevIns, pThis->hTimerRcvFifoTimeout, &pThis->CritSect);
-    AssertRCReturn(rc, rc);
-
     /*
      * Create the transmit timer when no device is connected.
      */
-    rc = PDMDevHlpTimerCreate(pDevIns, TMCLOCK_VIRTUAL, uartR3TxUnconnectedTimer, pThisCC,
+    rc = PDMDevHlpTimerCreate(pDevIns, TMCLOCK_VIRTUAL_SYNC, uartR3TxUnconnectedTimer, pThisCC,
                               TMTIMER_FLAGS_NO_CRIT_SECT, "UART TX uncon. Timer",
                               &pThis->hTimerTxUnconnected);
-    AssertRCReturn(rc, rc);
-
-    rc = PDMDevHlpTimerSetCritSect(pDevIns, pThis->hTimerTxUnconnected, &pThis->CritSect);
     AssertRCReturn(rc, rc);