Changeset 84328 in vbox for trunk

Timestamp:

May 18, 2020 1:34:32 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

138005

Message:

Storage/VD: ticketref:19579 'VBoxManage internalcommands repairhd' SEGVs with invalid input

File:

• trunk/src/VBox/Storage/VDPlugin.cpp (modified) (6 diffs)

trunk/src/VBox/Storage/VDPlugin.cpp

@@ -477 +477 @@
 DECLHIDDEN(int) vdFindImageBackend(const char *pszBackend, PCVDIMAGEBACKEND *ppBackend)
 {
-    int rc = VINF_SUCCESS;
+    int rc = VERR_NOT_FOUND;
     PCVDIMAGEBACKEND pBackend = NULL;
 
@@ -488 +488 @@
         {
             pBackend = g_apBackends[i];
+            rc = VINF_SUCCESS;
             break;
         }
@@ -532 +533 @@
 DECLHIDDEN(int) vdFindCacheBackend(const char *pszBackend, PCVDCACHEBACKEND *ppBackend)
 {
-    int rc = VINF_SUCCESS;
+    int rc = VERR_NOT_FOUND;
     PCVDCACHEBACKEND pBackend = NULL;
 
@@ -543 +544 @@
         {
             pBackend = g_apCacheBackends[i];
+            rc = VINF_SUCCESS;
             break;
         }
@@ -588 +590 @@
 DECLHIDDEN(int) vdFindFilterBackend(const char *pszFilter, PCVDFILTERBACKEND *ppBackend)
 {
-    int rc = VINF_SUCCESS;
+    int rc = VERR_NOT_FOUND;
     PCVDFILTERBACKEND pBackend = NULL;
 
@@ -596 +598 @@
         {
             pBackend = g_apFilterBackends[i];
+            rc = VINF_SUCCESS;
             break;
         }