Changeset 84472 in vbox

Timestamp:

May 23, 2020 12:53:37 PM (5 years ago)

Author:

vboxsync

Message:

ApplianceImplImport.cpp: r=bird @todo. bugref:9416

File:

• trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp

@@ -1428 +1428 @@
             if (SUCCEEDED(hrc))
             {
+                /** @todo r=bird: Please try find a less convoluted way of adding some random
+                 *        number to the name, we've got RTRandU64() for instance which you
+                 *        could combine with strVMName.appendPrintfNoThrow.
+                 *
+                 *        The code below is also accessing heap after it has been freed.
+                 *        Guid.toString() returns a Utf8Str object which expires and is deleted
+                 *        once strrchr returns.
+                 */
                 /* what to do? create a new name from the old one with some suffix? */
                 com::Guid newId;