Changeset 84537 in vbox for trunk/src/VBox/Frontends

Timestamp:

May 26, 2020 11:50:47 AM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Make sure menu update handlers called after menus were updated from the action-pool side; That's a common approach designed for the UIActionPool interface.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIVirtualBoxManager.cpp (modified) (7 diffs)
• UIVirtualBoxManager.h (modified) (5 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManager.cpp

@@ -365 +365 @@
 }
 
+void UIVirtualBoxManager::sltHandleMenuPrepare(int iIndex, QMenu *pMenu)
+{
+    /* Update if there is update-handler: */
+    if (m_menuUpdateHandlers.contains(iIndex))
+        (this->*(m_menuUpdateHandlers.value(iIndex)))(pMenu);
+}
+
 void UIVirtualBoxManager::sltOpenVirtualMediumManagerWindow()
 {
@@ -1377 +1384 @@
 }
 
-void UIVirtualBoxManager::sltGroupCloseMenuAboutToShow()
-{
-    /* Get selected items: */
-    QList<UIVirtualMachineItem*> items = currentItems();
-    AssertMsgReturnVoid(!items.isEmpty(), ("At least one item should be selected!\n"));
-
-    actionPool()->action(UIActionIndexST_M_Group_M_Close_S_Shutdown)->setEnabled(isActionEnabled(UIActionIndexST_M_Group_M_Close_S_Shutdown, items));
-}
-
-void UIVirtualBoxManager::sltMachineCloseMenuAboutToShow()
-{
-    /* Get selected items: */
-    QList<UIVirtualMachineItem*> items = currentItems();
-    AssertMsgReturnVoid(!items.isEmpty(), ("At least one item should be selected!\n"));
-
-    actionPool()->action(UIActionIndexST_M_Machine_M_Close_S_Shutdown)->setEnabled(isActionEnabled(UIActionIndexST_M_Machine_M_Close_S_Shutdown, items));
-}
-
 void UIVirtualBoxManager::prepare()
 {
@@ -1477 +1466 @@
     /* Create action-pool: */
     m_pActionPool = UIActionPool::create(UIActionPoolType_Manager);
+
+    /* Prepare menu update-handlers: */
+    m_menuUpdateHandlers[UIActionIndexST_M_Group_M_Close] = &UIVirtualBoxManager::updateMenuGroupClose;
+    m_menuUpdateHandlers[UIActionIndexST_M_Machine_M_Close] = &UIVirtualBoxManager::updateMenuMachineClose;
 
     /* Build menu-bar: */
@@ -1549 +1542 @@
     connect(gVBoxEvents, &UIVirtualBoxEventHandler::sigSessionStateChange,
             this, &UIVirtualBoxManager::sltHandleStateChange);
+
+    /* General action-pool connections: */
+    connect(actionPool(), &UIActionPool::sigNotifyAboutMenuPrepare, this, &UIVirtualBoxManager::sltHandleMenuPrepare);
 
     /* 'File' menu connections: */
@@ -1663 +1659 @@
 
     /* 'Group/Close' menu connections: */
-    connect(actionPool()->action(UIActionIndexST_M_Group_M_Close)->menu(), &UIMenu::aboutToShow,
-            this, &UIVirtualBoxManager::sltGroupCloseMenuAboutToShow);
     connect(actionPool()->action(UIActionIndexST_M_Group_M_Close_S_Detach), &UIAction::triggered,
             this, &UIVirtualBoxManager::sltPerformDetachMachineUI);
@@ -1675 +1669 @@
 
     /* 'Machine/Close' menu connections: */
-    connect(actionPool()->action(UIActionIndexST_M_Machine_M_Close)->menu(), &UIMenu::aboutToShow,
-            this, &UIVirtualBoxManager::sltMachineCloseMenuAboutToShow);
     connect(actionPool()->action(UIActionIndexST_M_Machine_M_Close_S_Detach), &UIAction::triggered,
             this, &UIVirtualBoxManager::sltPerformDetachMachineUI);
@@ -1905 +1897 @@
         }
     }
+}
+
+void UIVirtualBoxManager::updateMenuGroupClose(QMenu *)
+{
+    /* Get selected items: */
+    QList<UIVirtualMachineItem*> items = currentItems();
+    AssertMsgReturnVoid(!items.isEmpty(), ("At least one item should be selected!\n"));
+
+    actionPool()->action(UIActionIndexST_M_Group_M_Close_S_Shutdown)->setEnabled(isActionEnabled(UIActionIndexST_M_Group_M_Close_S_Shutdown, items));
+}
+
+void UIVirtualBoxManager::updateMenuMachineClose(QMenu *)
+{
+    /* Get selected items: */
+    QList<UIVirtualMachineItem*> items = currentItems();
+    AssertMsgReturnVoid(!items.isEmpty(), ("At least one item should be selected!\n"));
+
+    actionPool()->action(UIActionIndexST_M_Machine_M_Close_S_Shutdown)->setEnabled(isActionEnabled(UIActionIndexST_M_Machine_M_Close_S_Shutdown, items));
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManager.h

@@ -49 +49 @@
     Q_OBJECT;
 
+    /** Pointer to menu update-handler for this class: */
+    typedef void (UIVirtualBoxManager::*MenuUpdateHandler)(QMenu *pMenu);
+
 signals:
 
@@ -142 +145 @@
         /** Handles CVirtualBox event about state change for machine with @a uID. */
         void sltHandleStateChange(const QUuid &uID);
+    /** @} */
+
+    /** @name Action-pool stuff.
+      * @{ */
+        /** Handle menu prepare. */
+        void sltHandleMenuPrepare(int iIndex, QMenu *pMenu);
     /** @} */
 
@@ -266 +275 @@
         /** Handles call to toggle machine search widget visibility to be @a fVisible. */
         void sltPerformMachineSearchWidgetVisibilityToggling(bool fVisible);
-
-        /** Handles call to show group Close menu. */
-        void sltGroupCloseMenuAboutToShow();
-        /** Handles call to show machine Close menu. */
-        void sltMachineCloseMenuAboutToShow();
     /** @} */
 
@@ -339 +343 @@
     /** @name Action update stuff.
       * @{ */
+        /** Updates 'Group' : 'Close' menu. */
+        void updateMenuGroupClose(QMenu *pMenu);
+        /** Updates 'Machine' : 'Close' menu. */
+        void updateMenuMachineClose(QMenu *pMenu);
+
         /** Performs update of actions visibility. */
         void updateActionsVisibility();
@@ -386 +395 @@
     /** Holds the action-pool instance. */
     UIActionPool *m_pActionPool;
+    /** Holds the map of menu update-handlers. */
+    QMap<int, MenuUpdateHandler> m_menuUpdateHandlers;
 
     /** Holds the Virtual Media Manager window instance. */