Changeset 84569 in vbox for trunk/src/VBox/Frontends

Timestamp:

May 27, 2020 3:15:14 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

138299

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Chooser pane: A bit of cleanup; buildTreeForMainRoot function should be able to preserve selection if requested.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser

Files:

• UIChooserModel.cpp (modified) (9 diffs)
• UIChooserModel.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp

@@ -85 +85 @@
     /* Build tree for main root: */
     buildTreeForMainRoot();
-
     /* Load last selected-item: */
     loadLastSelectedItem();
@@ -947 +946 @@
         firstSelectedItem()->parentItem()->node()->sortNodes();
 
-    /* Remember first selected item definition: */
-    const QString strDefinition = firstSelectedItem() ? firstSelectedItem()->definition() : QString();
-
     /* Rebuild tree for main root: */
-    buildTreeForMainRoot();
-
-    /* Restore selection if there was some item before: */
-    if (!strDefinition.isNull())
-        setSelectedItem(strDefinition);
-    /* Else make sure at least one item selected: */
-    else
-        makeSureAtLeastOneItemSelected();
+    buildTreeForMainRoot(true /* preserve selection */);
 }
 
@@ -1089 +1078 @@
         {
             /* Rebuild tree for main root: */
-            buildTreeForMainRoot();
-
+            buildTreeForMainRoot(false /* preserve selection */);
             /* Select newly added item: */
             setSelectedItem(root()->searchForItem(uId.toString(),
@@ -1112 +1100 @@
     if (!fRegistered)
     {
-        /* Remember first selected item definition: */
-        const QString strDefinition = firstSelectedItem() ? firstSelectedItem()->definition() : QString();
-
         /* Rebuild tree for main root: */
-        buildTreeForMainRoot();
-
-        /* Restore selection if there was some item before: */
-        if (!strDefinition.isNull())
-            setSelectedItem(strDefinition);
-        /* Else make sure at least one item selected: */
-        else
-            makeSureAtLeastOneItemSelected();
+        buildTreeForMainRoot(true /* preserve selection */);
     }
     /* New VM registered? */
@@ -1129 +1107 @@
     {
         /* Rebuild tree for main root: */
-        buildTreeForMainRoot();
-
+        buildTreeForMainRoot(false /* preserve selection */);
         /* Select newly added item: */
         setSelectedItem(root()->searchForItem(uId.toString(),
@@ -1147 +1124 @@
     {
         /* Rebuild tree for main root: */
-        buildTreeForMainRoot();
-
+        buildTreeForMainRoot(false /* preserve selection */);
         /* Select newly added item: */
         setSelectedItem(root()->searchForItem(uId.toString(),
@@ -1171 +1147 @@
     UIChooserAbstractModel::sltHandleCloudListMachinesTaskComplete(pTask);
 
-    /* Remember first selected item definition: */
-    const QString strDefinition = firstSelectedItem() ? firstSelectedItem()->definition() : QString();
-
     /* Rebuild tree for main root: */
-    buildTreeForMainRoot();
-
-    /* Restore selection if there was some item before: */
-    if (!strDefinition.isNull())
-        setSelectedItem(strDefinition);
-    /* Make sure at least one item selected: */
-    if (!currentItem())
-        makeSureAtLeastOneItemSelected();
+    buildTreeForMainRoot(true /* preserve selection */);
 }
 
@@ -1570 +1536 @@
 }
 
-void UIChooserModel::buildTreeForMainRoot()
-{
+void UIChooserModel::buildTreeForMainRoot(bool fPreserveSelection /* = false */)
+{
+    /* Remember first selected item if requested: */
+    QString strSelectedItemDefinition;
+    if (fPreserveSelection && firstSelectedItem())
+        strSelectedItemDefinition = firstSelectedItem()->definition();
+
     /* Cleanup previous tree if exists: */
     delete m_pRoot;
@@ -1585 +1556 @@
     /* Update tree for main root: */
     updateTreeForMainRoot();
+
+    /* Restore selection if requested: */
+    if (fPreserveSelection)
+    {
+        setSelectedItem(strSelectedItemDefinition);
+        makeSureAtLeastOneItemSelected();
+    }
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.h

@@ -361 +361 @@
     /** @name Children stuff.
       * @{ */
-        /** Build tree for main root. */
-        void buildTreeForMainRoot();
+        /** [Re]builds tree for main root, preserves selection if requested. */
+        void buildTreeForMainRoot(bool fPreserveSelection = false);
         /** Update tree for main root. */
         void updateTreeForMainRoot();