Changeset 84593 in vbox for trunk/src/VBox/Additions

Timestamp:

May 28, 2020 2:33:35 PM (5 years ago)

Author:

vboxsync

Message:

bugref:9637. dont lose effective user id

File:

• trunk/src/VBox/Additions/x11/VBoxClient/display-drm.cpp (modified) (5 diffs)

trunk/src/VBox/Additions/x11/VBoxClient/display-drm.cpp

@@ -106 +106 @@
 static void drmConnect(struct DRMCONTEXT *pContext)
 {
+    uid_t guid = getuid();
+    if (setreuid(0, 0) == -1)
+    {
+        perror("setuid failed drm device open.");
+    }
     unsigned i;
     RTFILE hDevice;
@@ -145 +150 @@
     }
     pContext->hDevice = hDevice;
+    setreuid(guid, 0);
 }
 
@@ -163 +169 @@
 {
     uid_t guid = getuid();
-    if (setuid(0) == -1)
-    {
-        perror("setuid failed during drm ioctl.");
+    if (setreuid(0, 0) == -1)
+    {
+        perror("setuid failed drm device open.");
     }
 
@@ -179 +185 @@
     if (RT_FAILURE(rc) && rc != VERR_INVALID_PARAMETER)
         VBClLogFatalError("Failure updating layout, rc=%Rrc\n", rc);
-    setuid(guid);
+    setreuid(guid, 0);
 }
 
 int main(int argc, char *argv[])
 {
-    uid_t guid = getuid();
-    if (setuid(0) == -1)
-    {
-        perror("setuid failed during init.");
-    }
-
     int rc = RTR3InitExe(argc, &argv, 0);
     if (RT_FAILURE(rc))
@@ -223 +223 @@
         return VERR_INVALID_HANDLE;
     }
-    setuid(guid);
+
     for (;;)
     {