Changeset 84623 in vbox

Timestamp:

May 31, 2020 5:15:24 PM (5 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9653: VirtualBox Manager: Details pane: While switching details from one VM to another, we have to clear details set from stale machine-item, machine and cloud machine information; This has to be done cause details rebuild process is async and takes a while, and previous data can became stale during it.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/details

Files:

• UIDetailsGroup.cpp (modified) (1 diff)
• UIDetailsSet.cpp (modified) (4 diffs)
• UIDetailsSet.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsGroup.cpp

@@ -89 +89 @@
 
     /* Cleanup superflous items: */
-    bool fCleanupPerformed = m_items.size() > m_machineItems.size();
+    const bool fCleanupPerformed = m_items.size() > m_machineItems.size();
     while (m_items.size() > m_machineItems.size())
         delete m_items.last();
+    foreach (UIDetailsItem *pItem, m_items)
+        pItem->toSet()->clearSet();
     if (fCleanupPerformed)
         updateGeometry();

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsSet.cpp

@@ -62 +62 @@
     /* Remove set from the parent group: */
     parentItem()->removeItem(this);
+}
+
+void UIDetailsSet::clearSet()
+{
+    /* Clear passed arguments: */
+    m_pMachineItem = 0;
+    m_comMachine = CMachine();
+    m_comCloudMachine = CCloudMachine();
 }
 
@@ -568 +576 @@
         return;
 
+    /* Make sure VM is set: */
+    if (m_comMachine.isNull())
+        return;
+
     /* Is this our VM changed? */
     if (m_comMachine.GetId() != uId)
@@ -582 +594 @@
         return;
 
+    /* Make sure VM is set: */
+    if (m_comMachine.isNull())
+        return;
+
     /* Is this our VM changed? */
     if (m_comMachine.GetId() != uId)
@@ -594 +610 @@
     /* For local VMs only: */
     if (!m_fIsLocal)
+        return;
+
+    /* Make sure VM is set: */
+    if (m_comMachine.isNull())
         return;
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/details/UIDetailsSet.h

@@ -55 +55 @@
     /** @name Item stuff.
       * @{ */
+        /** Cleanups set, wiping out machine-item and [cloud]machine information for good. */
+        void clearSet();
         /** Builds set based on passed @a pMachineItem.
           * @param  fFullSet  Brigns whether full set should be built.