Changeset 84628 in vbox

Timestamp:

Jun 1, 2020 8:23:07 PM (4 years ago)

Author:

vboxsync

Message:

Debugger: Initial port of my GDB stub library from ​​https://github.com/AlexanderEichner/libgdbstub to VirtualBox, ​bugref:5217 [build and doxygen fixes]

File:

• trunk/src/VBox/Debugger/DBGCGdbRemoteStub.cpp (modified) (10 diffs)

trunk/src/VBox/Debugger/DBGCGdbRemoteStub.cpp

@@ -109 +109 @@
     size_t                      cbPktBufMax;
     /** Current offset into the packet buffer. */
-    uint32_t                    offPktBuf;
+    size_t                      offPktBuf;
     /** The size of the packet (minus the start, end characters and the checksum). */
     uint32_t                    cbPkt;
@@ -293 +293 @@
  * @returns Status code.
  * @param   pThis               The GDB stub context.
- * @param   pbReplyData         The reply data to send.
+ * @param   pvReplyData         The reply data to send.
  * @param   cbReplyData         Size of the reply data in bytes.
  */
@@ -330 +330 @@
  * @returns Status code.
  * @param   pThis               The GDB stub context.
- * @param   pbReplyPkt          The reply packet to send.
+ * @param   pvReplyPkt          The reply packet to send.
  * @param   cbReplyPkt          Size of the reply packet in bytes.
  */
@@ -604 +604 @@
 
 /**
- * @copydoc{FNGDBSTUBQPKTPROC}
+ * @copydoc FNGDBSTUBQPKTPROC
  */
 static int dbgcGdbStubCtxPktProcessFeatXmlRegs(PGDBSTUBCTX pThis, const uint8_t *pbVal, size_t cbVal)
@@ -784 +784 @@
 
 /**
- * Sends the reply to a 'qXfer:<object>:read:...' request.
+ * Sends the reply to a 'qXfer:object:read:...' request.
  *
  * @returns Status code.
@@ -810 +810 @@
         }
         else
-            rc = dbgcGdbStubCtxReplySendErr(pThis, VERR_NO_MEMORY);
+            rc = dbgcGdbStubCtxReplySendErrSts(pThis, VERR_NO_MEMORY);
     }
     else if (offRead == cbObj)
@@ -822 +822 @@
 
 /**
- * Parses the annex:offset,length part of a 'qXfer:<object>:read:...' request.
- *
- * @returns Status code.
- * @param   pbArgs              Start of the arguments beginning with <annex>.
+ * Parses the annex:offset,length part of a 'qXfer:object:read:...' request.
+ *
+ * @returns Status code.
+ * @param   pbArgs              Start of the arguments beginning with annex.
  * @param   cbArgs              Number of bytes remaining for the arguments.
  * @param   ppchAnnex           Where to store the pointer to the beginning of the annex on success.
  * @param   pcchAnnex           Where to store the number of characters for the annex on success.
- * @param   poff                Where to store the offset on success.
- * @param   pcb                 Where to store the length on success.
+ * @param   poffRead            Where to store the offset on success.
+ * @param   pcbRead             Where to store the length on success.
  */
 static int dbgcGdbStubCtxPktProcessQueryXferParseAnnexOffLen(const uint8_t *pbArgs, size_t cbArgs, const char **ppchAnnex, size_t *pcchAnnex,
@@ -1456 +1456 @@
                 {
                     size_t cbProcessed = pbPktSep - &pThis->pbPktBuf[2];
-                    size_t cbRead = 0;
+                    uint64_t cbRead = 0;
                     rc = dbgcGdbStubCtxParseHexStringAsInteger(pbPktSep + 1, pThis->cbPkt - 1 - cbProcessed - 1, &cbRead, GDBSTUB_PKT_END, NULL);
                     if (RT_SUCCESS(rc))
@@ -1516 +1516 @@
                 {
                     size_t cbProcessed = pbPktSep - &pThis->pbPktBuf[2];
-                    size_t cbWrite = 0;
+                    uint64_t cbWrite = 0;
                     rc = dbgcGdbStubCtxParseHexStringAsInteger(pbPktSep + 1, pThis->cbPkt - 1 - cbProcessed - 1, &cbWrite, ':', &pbPktSep);
                     if (RT_SUCCESS(rc))
@@ -2166 +2166 @@
  *
  * @returns VBox status code.
- * @param   pDbgc   Pointer to the debugger console instance data.
+ * @param   pThis   Pointer to the GDB stub context.
  */
 int dbgcGdbStubRun(PGDBSTUBCTX pThis)