Changeset 84668 in vbox for trunk/src/VBox/ValidationKit/tests/additions

Timestamp:

Jun 3, 2020 3:43:31 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

138425

Message:

Validation Kit/tdAddGuestCtrl.py: Trying to fix the GA runlevel tests.

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddBasic1.py (modified) (5 diffs)

trunk/src/VBox/ValidationKit/tests/additions/tdAddBasic1.py

@@ -57 +57 @@
 
 
-
-class tdAddBasicConsoleCallbacks(vbox.ConsoleEventHandlerBase):
-    """
-    For catching the Guest Additions change state events.
-    """
-    def __init__(self, dArgs):
-        oTstDrv  = dArgs['oTstDrv'];
-        oVBoxMgr = dArgs['oVBoxMgr']; _ = oVBoxMgr;
-        oGuest   = dArgs['oGuest'];
-
-        vbox.ConsoleEventHandlerBase.__init__(self, dArgs, 'tdAddBasic1');
-        self.oTstDrv  = oTstDrv;
-        self.oGuest   = oGuest;
-
-    def handleEvent(self, oEvt):
-        try:
-            oEvtBase = self.oVBoxMgr.queryInterface(oEvt, 'IEvent');
-            eType = oEvtBase.type;
-        except:
-            reporter.logXcpt();
-            return None;
-        if eType == vboxcon.VBoxEventType_OnAdditionsStateChanged:
-            return self.onAdditionsStateChanged();
-        return None;
-
-    def onAdditionsStateChanged(self):
-        reporter.log('onAdditionsStateChange');
-        self.oTstDrv.fGAStatusCallbackFired = True;
-        self.oTstDrv.eGAStatusCallbackRunlevel = self.oGuest.additionsRunLevel;
-        self.oVBoxMgr.interruptWaitEvents();
-        return None;
-
 class tdAddBasic1(vbox.TestDriver):                                         # pylint: disable=too-many-instance-attributes
     """
@@ -108 +76 @@
         self.addSubTestDriver(SubTstDrvAddGuestCtrl(self));
         self.addSubTestDriver(SubTstDrvAddSharedFolders1(self));
-
-        self.fGAStatusCallbackFired    = False;
-        self.eGAStatusCallbackRunlevel = 0;
 
     #
@@ -291 +256 @@
         return fRc;
 
-    def waitForGuestAdditionsRunLevel(self, oSession, oGuest, cMsTimeout, eRunLevel):
-        """
-        Waits for the Guest Additions to reach a specific run level.
-
-        Returns success status.
-        """
-        # No need to wait as we already reached the run level?
-        eRunLevelCur = oGuest.additionsRunLevel;
-        if eRunLevelCur == eRunLevel:
-            reporter.log('Already reached run level %s' % eRunLevel);
-            return True;
-
-        reporter.log('Waiting for Guest Additions to reach run level %s with %dms (current: %s) ...' %
-                     (eRunLevel, cMsTimeout, eRunLevelCur));
-
-        oConsoleCallbacks = oSession.registerDerivedEventHandler(tdAddBasicConsoleCallbacks, \
-                                                                 {'oTstDrv':self, 'oGuest':oGuest, });
-        fRc = False;
-        if oConsoleCallbacks is not None:
-            tsStart = base.timestampMilli();
-            while base.timestampMilli() - tsStart < cMsTimeout:
-                self.sleep(1); # Do some busy waiting.
-                if self.fGAStatusCallbackFired:
-                    reporter.log('Reached new run level %s after %dms' %
-                                 (self.eGAStatusCallbackRunlevel, base.timestampMilli() - tsStart));
-                    if eRunLevel == self.eGAStatusCallbackRunlevel:
-                        fRc = True;
-                        break;
-                    self.fGAStatusCallbackFired = False;
-            if fRc:
-                reporter.log('Final Guest Additions run level reached after %dms' % (base.timestampMilli() - tsStart));
-            else:
-                reporter.error('Guest Additions run level not reached');
-
-            # cleanup.
-            oConsoleCallbacks.unregister();
-        else:
-            reporter.error('Registering derived event handler failed');
-
-        if not fRc:
-            reporter.log('Waiting for Guest Additions to reach run level %s failed' % (eRunLevel));
-        return fRc;
-
     def testInstallAdditions(self, oSession, oTxsSession, oTestVm):
         """
@@ -539 +461 @@
         Do run level tests.
         """
+
+        _ = oGuest;
+
         if oTestVm.isWindows():
             if oTestVm.isLoggedOntoDesktop():
@@ -548 +473 @@
             eExpectedRunLevel = vboxcon.AdditionsRunLevelType_Userland;
 
-        return self.waitForGuestAdditionsRunLevel(oSession, oGuest, 5 * 60 * 1000, eExpectedRunLevel);
+        return self.waitForGAs(oSession, aenmWaitForRunLevels = [ eExpectedRunLevel ]);
 
     def testIGuest_additionsVersion(self, oGuest):