Changeset 84720 in vbox for trunk/src/VBox/Additions

Timestamp:

Jun 8, 2020 7:51:42 AM (5 years ago)

Author:

vboxsync

Message:

Guest Additions/VBoxTray: Be more verbose when a certain service does not start; added more documentation about how to treat service starting failures.

Location:

trunk/src/VBox/Additions/WINNT/VBoxTray

Files:

• VBoxTray.cpp (modified) (1 diff)
• VBoxTray.h (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxTray.cpp

@@ -312 +312 @@
         if (RT_FAILURE(rc2))
         {
-            LogRel(("Failed to initialize service '%s', rc=%Rrc\n", pSvc->pDesc->pszName, rc2));
-            if (rc2 == VERR_NOT_SUPPORTED)
+            switch (rc2)
             {
-                LogRel(("Service '%s' is not supported on this system\n", pSvc->pDesc->pszName));
-                rc2 = VINF_SUCCESS;
+                case VERR_NOT_SUPPORTED:
+                    LogRel(("Service '%s' is not supported on this system\n", pSvc->pDesc->pszName));
+                    rc2 = VINF_SUCCESS; /* Keep going. */
+                    break;
+
+                case VERR_HGCM_SERVICE_NOT_FOUND:
+                    LogRel(("Service '%s' is not available on the host\n", pSvc->pDesc->pszName));
+                    rc2 = VINF_SUCCESS; /* Keep going. */
+                    break;
+
+                default:
+                    LogRel(("Failed to initialize service '%s', rc=%Rrc\n", pSvc->pDesc->pszName, rc2));
+                    break;
             }
-            /* Keep going. */
         }
         else

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxTray.h

@@ -91 +91 @@
      * Initializes a service.
      * @returns VBox status code.
+     *          VERR_NOT_SUPPORTED if the service is not supported on this guest system. Logged.
+     *          VERR_HGCM_SERVICE_NOT_FOUND if the service is not available on the host system. Logged.
+     *          Returning any other error will be considered as a fatal error.
      * @param   pEnv
      * @param   ppInstance      Where to return the thread-specific instance data.