Changeset 84736 in vbox

Timestamp:

Jun 9, 2020 11:27:56 AM (5 years ago)

Author:

vboxsync

Message:

Validation Kit/tdAddGuestCtrl.py: More Windows-specific tweaking wrt long arguments testing.

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

@@ -2958 +2958 @@
                             tdTestResultExec(fRc = True) ]);
 
-        # Test very long arguments.
-        # Old(er) Windows OSes tend to crash in cmd.exe, so skip this.
+        # Test very long arguments. Be careful when tweaking this to not break the tests.
         # Regarding paths:
         # - We have RTPATH_BIG_MAX (64K)
@@ -2965 +2964 @@
         # - On Windows, each path component must not be longer than MAX_PATH (260), see
         #   https://docs.microsoft.com/en-us/windows/win32/fileio/filesystem-functionality-comparison#limits
+        #
+        # Old(er) Windows OSes tend to crash in cmd.exe, so skip this on these OSes.
         if  self.oTstDrv.fpApiVer >= 6.1 \
         and oTestVm.sKind not in ('WindowsNT4', 'Windows2000', 'WindowsXP', 'Windows2003'):
@@ -2982 +2983 @@
 
                 # Append a random number of arguments with random length.
-                for _ in xrange(0, self.oTestFiles.oRandom.randrange(1, 16)):
+                for _ in xrange(0, self.oTestFiles.oRandom.randrange(1, 64)):
                     asArgs.append(''.join(random.choice(string.lowercase)
-                                          for _ in range(self.oTestFiles.oRandom.randrange(1, 16 * 1024))));
+                                          for _ in range(self.oTestFiles.oRandom.randrange(1, 255))));
 
                 asArgs.append(sEndMarker);