Changeset 84744 in vbox for trunk/src/VBox/Main

Timestamp:

Jun 9, 2020 6:55:07 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

138538

Message:

Guest Control/Main: Refined API error logging. bugref:9320

Location:

trunk/src/VBox/Main/src-client

Files:

• GuestFileImpl.cpp (modified) (2 diffs)
• GuestProcessImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/GuestFileImpl.cpp

@@ -1688 +1688 @@
     int vrc = i_writeData(aTimeoutMS, pvData, cbData, (uint32_t*)aWritten);
     if (RT_FAILURE(vrc))
-        hr = setErrorBoth(VBOX_E_IPRT_ERROR, vrc, tr("Writing %zubytes to guest file \"%s\" failed: %Rrc"),
+        hr = setErrorBoth(VBOX_E_IPRT_ERROR, vrc, tr("Writing %zu bytes to guest file \"%s\" failed: %Rrc"),
                           aData.size(), mData.mOpenInfo.mFilename.c_str(), vrc);
 
@@ -1711 +1711 @@
     int vrc = i_writeDataAt(aOffset, aTimeoutMS, pvData, cbData, (uint32_t*)aWritten);
     if (RT_FAILURE(vrc))
-        hr = setErrorBoth(VBOX_E_IPRT_ERROR, vrc, tr("Writing %zubytes to file \"%s\" (at offset %RU64) failed: %Rrc"),
+        hr = setErrorBoth(VBOX_E_IPRT_ERROR, vrc, tr("Writing %zu bytes to file \"%s\" (at offset %RU64) failed: %Rrc"),
                           aData.size(), mData.mOpenInfo.mFilename.c_str(), aOffset, vrc);
 

trunk/src/VBox/Main/src-client/GuestProcessImpl.cpp

@@ -1787 +1787 @@
         {
             case VERR_GSTCTL_GUEST_ERROR:
-                hr = setErrorExternal(this, "Reading from guest process failed",
+                hr = setErrorExternal(this, Utf8StrFmt("Reading %RU32 bytes from guest process handle %RU32 failed", aToRead, aHandle),
                                       GuestErrorInfo(GuestErrorInfo::Type_Process, rcGuest, mData.mProcess.mExecutable.c_str()));
                 break;
@@ -1879 +1879 @@
         {
             case VERR_GSTCTL_GUEST_ERROR:
-                hr = setErrorExternal(this, "Waiting for guest process failed",
+                hr = setErrorExternal(this, Utf8StrFmt("Waiting for guest process (flags %#x) failed", aWaitFor),
                                       GuestErrorInfo(GuestErrorInfo::Type_Process, rcGuest, mData.mProcess.mExecutable.c_str()));
                 break;
@@ -1933 +1933 @@
         {
             case VERR_GSTCTL_GUEST_ERROR:
-                hr = setErrorExternal(this, "Writing to guest process failed",
+                hr = setErrorExternal(this, Utf8StrFmt("Writing %RU32 bytes (flags %#x) to guest process failed", cbData, aFlags),
                                       GuestErrorInfo(GuestErrorInfo::Type_Process, rcGuest, mData.mProcess.mExecutable.c_str()));
                 break;