Changeset 84881 in vbox for trunk/src/VBox/Additions

Timestamp:

Jun 19, 2020 12:42:31 PM (5 years ago)

Author:

vboxsync

Message:

Guest Control/VBoxServce: Fixed removing a (not yet started) process from a guest session's process list in case of early failures in the process thread. Needed in order to avoid process cleanup hangs. bugref:9320.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlProcess.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlProcess.cpp

@@ -1855 +1855 @@
                        pStartupInfo->pszCmd, rc, pProcess);
 
+            /* Process has not been added to the session's process list yet, so skip VGSvcGstCtrlSessionProcessRemove() here. */
             VGSvcGstCtrlProcessFree(pProcess);
         }
@@ -1872 +1873 @@
                 if (RT_SUCCESS(rc2))
                     pProcess->Thread = NIL_RTTHREAD;
+
+                VGSvcGstCtrlSessionProcessRemove(pSession, pProcess);
                 VGSvcGstCtrlProcessFree(pProcess);
             }