Changeset 84888 in vbox for trunk/src/VBox/Devices/Graphics

Timestamp:

Jun 21, 2020 6:41:16 PM (4 years ago)

Author:

vboxsync

Message:

FE/Qt,Devices/Graphics: experimental GLX graphics output: use TEXTURE_2D

File:

• trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-ogl.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-ogl.cpp

@@ -3514 +3514 @@
      */
 
-    /* FBConfig attributes. */
+    /* FBConfig attributes.
+     * Using TEXTURE_2D because Intel Mesa driver does not seem to support TEXTURE_RECTANGLE for GLX pixmaps.
+     */
     static int const aConfigAttribList[] =
     {
@@ -3522 +3524 @@
         GLX_DRAWABLE_TYPE,               GLX_PIXMAP_BIT,         // Must support GLX pixmaps
         GLX_BIND_TO_TEXTURE_RGBA_EXT,    True,                   // Must support GLX_EXT_texture_from_pixmap
-        GLX_BIND_TO_TEXTURE_TARGETS_EXT, GLX_TEXTURE_RECTANGLE_BIT_EXT, // Must support GL_TEXTURE_RECTANGLE for the frontend code
+        GLX_BIND_TO_TEXTURE_TARGETS_EXT, GLX_TEXTURE_2D_BIT_EXT, // Must support GL_TEXTURE_2D for the frontend code
         GLX_DOUBLEBUFFER,                False,                  // No need for double buffering for a pixmap.
         GLX_RED_SIZE,                    8,                      // True color RGB with 8 bits per channel.
@@ -3570 +3572 @@
                 continue;
 
-            /* Pixmap will be used as TEXTURE_RECTANGLE. */
+            /* Pixmap will be used as TEXTURE_2D. */
             glXGetFBConfigAttrib(pState->display, paConfigs[i], GLX_BIND_TO_TEXTURE_TARGETS_EXT, &value);
-            if (!(value & GLX_TEXTURE_RECTANGLE_BIT_EXT))
+            if (!(value & GLX_TEXTURE_2D_BIT_EXT))
                 continue;
 
@@ -3605 +3607 @@
             static int const aPixmapAttribList[] =
             {
-                GLX_TEXTURE_TARGET_EXT, GLX_TEXTURE_RECTANGLE_EXT,
+                GLX_TEXTURE_TARGET_EXT, GLX_TEXTURE_2D_EXT,
                 GLX_TEXTURE_FORMAT_EXT, GLX_TEXTURE_FORMAT_RGBA_EXT,
                 GLX_MIPMAP_TEXTURE_EXT, p->fMipmap,
@@ -3731 +3733 @@
     else
     {
+        LogRel4(("VMSVGA: vmsvga3dBackDefineScreen: %Rrc\n", rc));
         vmsvga3dHwScreenDestroy(pState, p);
         RTMemFree(p);