Changeset 85000 in vbox for trunk/src/VBox/Runtime

Timestamp:

Jun 29, 2020 4:51:21 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

138895

Message:

IPRT/http: Provide curl with an error buffer (fixed size array in
RTHTTPINTERNAL) where it can write error details that are otherwise
all hidden behind a single CURLcode.

File:

• trunk/src/VBox/Runtime/generic/http-curl.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/generic/http-curl.cpp

@@ -268 +268 @@
     /** @} */
 
+    /** Buffer for human readable error messages from curl on failures or problems. */
+    char szErrorBuffer[CURL_ERROR_SIZE];
 } RTHTTPINTERNAL;
 /** Pointer to an internal HTTP client instance. */
@@ -398 +400 @@
                 pThis->offUploadContent         = 0;
 
+                /* ask curl to give us back error messages */
+                curl_easy_setopt(pThis->pCurl, CURLOPT_ERRORBUFFER, pThis->szErrorBuffer);
 
                 *phHttp = (RTHTTP)pThis;
@@ -2841 +2845 @@
                 break;
         }
-        Log(("rtHttpGetCalcStatus: rc=%Rrc rcCurl=%u\n", rc, rcCurl));
+        Log(("%s: %Rrc: %u = %s%s%.*s\n",
+             __FUNCTION__,
+             rc, rcCurl, curl_easy_strerror((CURLcode)rcCurl),
+             pThis->szErrorBuffer[0] != '\0' ? ": " : "",
+             (int) sizeof(pThis->szErrorBuffer),
+             pThis->szErrorBuffer[0] != '\0' ? pThis->szErrorBuffer : ""));
     }