Changeset 85153 in vbox for trunk/src/VBox/Devices

Timestamp:

Jul 9, 2020 3:48:59 PM (5 years ago)

Author:

vboxsync

Message:

Devices/Graphics: Release texture object on failure, bugref:9747

File:

• trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-win.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA-SVGA3d-win.cpp

@@ -1933 +1933 @@
                                                   &pSurface->bounce.pTexture,
                                                   NULL);
-            AssertMsgReturn(hr == D3D_OK, ("CreateTexture (systemmem) failed with %x\n", hr), VERR_INTERNAL_ERROR);
-        }
+
+            AssertMsgReturnStmt(hr == D3D_OK,
+                ("CreateTexture (systemmem) failed with %x\n", hr),
+                D3D_RELEASE(pSurface->u.pTexture),
+                VERR_INTERNAL_ERROR);
+        }
+
         AssertMsgReturn(hr == D3D_OK, ("CreateTexture INTZ failed with %x\n", hr), VERR_INTERNAL_ERROR);
 
@@ -2011 +2016 @@
                                                       &pSurface->bounce.pTexture,
                                                       NULL);
-                AssertMsgReturn(hr == D3D_OK, ("CreateTexture (systemmem) failed with %x\n", hr), VERR_INTERNAL_ERROR);
+                AssertMsgReturnStmt(hr == D3D_OK,
+                    ("CreateTexture (systemmem) failed with %x\n", hr),
+                    D3D_RELEASE(pSurface->u.pTexture),
+                    VERR_INTERNAL_ERROR);
 
                 if (pSurface->formatD3D != pSurface->d3dfmtRequested)