Changeset 85220 in vbox

Timestamp:

Jul 11, 2020 3:42:34 PM (4 years ago)

Author:

vboxsync

Message:

VBoxManageGuestCtrl.cpp: Must not use RT_ZERO on pCtx in gctrCmdCtxInit as the struct contains 5 C++ objects. bugref:9790.

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -695 +695 @@
 static RTEXITCODE gctrCmdCtxInit(PGCTLCMDCTX pCtx, HandlerArg *pArg)
 {
-    RT_ZERO(*pCtx);
-    pCtx->pArg = pArg;
+    pCtx->pArg                      = pArg;
+    pCtx->pCmdDef                   = NULL;
+    pCtx->pszVmNameOrUuid           = NULL;
+    pCtx->fPostOptionParsingInited  = false;
+    pCtx->fLockedVmSession          = false;
+    pCtx->fDetachGuestSession       = false;
+    pCtx->fInstalledSignalHandler   = false;
+    pCtx->cVerbose                  = 0;
+    pCtx->strUsername.setNull();
+    pCtx->strPassword.setNull();
+    pCtx->strDomain.setNull();
+    pCtx->pGuest.setNull();
+    pCtx->pGuestSession.setNull();
+    pCtx->uSessionID                = 0;
 
     /*
@@ -704 +716 @@
     int rc = RTProcQueryUsername(RTProcSelf(), szUser, sizeof(szUser), NULL);
     if (   RT_SUCCESS(rc)
-        && RTStrIsValidEncoding(szUser)) /* paranoia required on posix */
+        && RTStrIsValidEncoding(szUser)) /* paranoia was required on posix at some point, not needed any more! */
     {
         try