Changeset 85233 in vbox

Timestamp:

Jul 11, 2020 4:30:55 PM (4 years ago)

Author:

vboxsync

Message:

Main/ExtPackUtil.cpp: Fixed a error string construction bug in VBoxExtPackLoadDesc, simplified the others. bugref:9790

File:

• trunk/src/VBox/Main/src-all/ExtPackUtil.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-all/ExtPackUtil.cpp

@@ -251 +251 @@
     int vrc = RTPathJoin(szFilePath, sizeof(szFilePath), a_pszDir, VBOX_EXTPACK_DESCRIPTION_NAME);
     if (RT_FAILURE(vrc))
-        return new RTCString("RTPathJoin failed with %Rrc", vrc);
+        return new RTCStringFmt("RTPathJoin failed with %Rrc", vrc);
 
     RTFSOBJINFO ObjInfo;
     vrc = RTPathQueryInfoEx(szFilePath, &ObjInfo,  RTFSOBJATTRADD_UNIX, RTPATH_F_ON_LINK);
     if (RT_FAILURE(vrc))
-        return &(new RTCString())->printf("RTPathQueryInfoEx failed with %Rrc", vrc);
+        return new RTCStringFmt("RTPathQueryInfoEx failed with %Rrc", vrc);
     if (a_pObjInfo)
         *a_pObjInfo = ObjInfo;
@@ -263 +263 @@
         if (RTFS_IS_SYMLINK(ObjInfo.Attr.fMode))
             return new RTCString("The XML file is symlinked, that is not allowed");
-        return &(new RTCString)->printf("The XML file is not a file (fMode=%#x)", ObjInfo.Attr.fMode);
+        return new RTCStringFmt("The XML file is not a file (fMode=%#x)", ObjInfo.Attr.fMode);
     }