Changeset 85245 in vbox

Timestamp:

Jul 11, 2020 11:07:43 PM (5 years ago)

Author:

vboxsync

Message:

Main/PCIDeviceAttachmentImpl.cpp: Signed/unsigned conversion issues. bugref:9790

File:

• trunk/src/VBox/Main/src-all/PCIDeviceAttachmentImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-all/PCIDeviceAttachmentImpl.cpp

@@ -94 +94 @@
                                             const settings::HostPCIDeviceAttachment &hpda)
 {
-    return init(aParent, hpda.strDeviceName, hpda.uHostAddress, hpda.uGuestAddress, TRUE);
+    /** @todo r=bird: Inconsistent signed/unsigned crap. */
+    return init(aParent, hpda.strDeviceName, (LONG)hpda.uHostAddress, (LONG)hpda.uGuestAddress, TRUE);
 }
 
@@ -101 +102 @@
 {
     Assert(m);
-    data.uHostAddress = m->HostAddress;
-    data.uGuestAddress = m->GuestAddress;
+    /** @todo r=bird: Inconsistent signed/unsigned crap. */
+    data.uHostAddress  = (uint32_t)m->HostAddress;
+    data.uGuestAddress = (uint32_t)m->GuestAddress;
     data.strDeviceName = m->DevName;