Changeset 85267 in vbox for trunk/src/VBox/Main/src-server/generic

Timestamp:

Jul 12, 2020 1:09:57 AM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

139244

Message:

Main/NetIf-generic.cpp: Made NetIfAdpCtl() return failure when the exit code is non-zero or it terminated abnormally (judging from the error messages, this is what the callers expects). Tried to untangle status code mess in NetIfCreateHostOnlyNetworkInterface(), adding missing error handling for popen() and adjusting some of the copy&paste error messages a little. NetIfRemoveHostOnlyNetworkInterface() should not call i_notifyComplete on an uninitialized progress object, and the return of Progress::init() is not a vbox status code that this function can return unconverted. createObject can fail. [build fix] bugref:9790

File:

• trunk/src/VBox/Main/src-server/generic/NetIf-generic.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/generic/NetIf-generic.cpp

@@ -200 +200 @@
     int vrc = VINF_SUCCESS;
     ComPtr<IHost> host;
-    HRESULT hrc = pVirtualBox->COMGETTER(Host)(host.asOutParam());
+    hrc = pVirtualBox->COMGETTER(Host)(host.asOutParam());
     if (SUCCEEDED(hrc))
     {