Changeset 85290 in vbox for trunk/src/VBox/Main/idl

Timestamp:

Jul 13, 2020 12:22:45 AM (4 years ago)

Author:

vboxsync

Message:

Main/comimpl.xsl(VBoxEvents.*): Made the internal setter methods inline and return non-S_OK on allocation failures. bugref:9790

File:

• trunk/src/VBox/Main/idl/comimpl.xsl (modified) (3 diffs)

trunk/src/VBox/Main/idl/comimpl.xsl

@@ -213 +213 @@
       </xsl:variable>
       <xsl:value-of select="concat('         SafeArray&lt;', $elemtype, '&gt; aArr(ComSafeArrayInArg(',$param,'));&#10;')"/>
-      <xsl:value-of select="concat('         ',$member, '.initFrom(aArr);&#10;')"/>
+      <xsl:value-of select="concat('         return ',$member, '.initFrom(aArr);&#10;')"/>
+    </xsl:when>
+    <xsl:when test="($type='wstring') or ($type='uuid')">
+      <xsl:value-of select="concat('         return ',$member, '.assignEx(', $param, ');&#10;')"/>
     </xsl:when>
     <xsl:otherwise>
       <xsl:value-of select="concat('         ', $member, ' = ', $param, ';&#10;')"/>
+      <xsl:value-of select="       '         return S_OK;&#10;'" />
     </xsl:otherwise>
   </xsl:choose>
@@ -453 +457 @@
         <xsl:with-param name="safearray" select="@safearray" />
       </xsl:call-template>
-      <xsl:value-of select="       '         return S_OK;&#10;'" />
       <xsl:value-of select="       '    }&#10;'" />
     </xsl:if>
 
     <xsl:value-of select="       '    // purely internal setter&#10;'" />
-    <xsl:value-of select="concat('    HRESULT set_', @name,'(',$pTypeNameIn, ')&#10;    {&#10;')" />
+    <xsl:value-of select="concat('    inline HRESULT set_', @name,'(',$pTypeNameIn, ')&#10;    {&#10;')" />
     <xsl:call-template name="genSetParam">
       <xsl:with-param name="type" select="@type" />
@@ -465 +468 @@
       <xsl:with-param name="safearray" select="@safearray" />
     </xsl:call-template>
-    <xsl:value-of select="       '         return S_OK;&#10;'" />
     <xsl:value-of select="       '    }&#10;'" />
   </xsl:for-each>