Changeset 85343 in vbox for trunk/src/VBox

Timestamp:

Jul 14, 2020 4:07:28 PM (5 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

139324

Message:

IPRT/RTCrStoreCreateSnapshotById-darwin.cpp: Ignore deprecation warnings for SecKeychainSearchCreateFromAttributes and SecKeychainSearchCopyNext for now (see @todo why). bugref:9790

File:

• trunk/src/VBox/Runtime/r3/darwin/RTCrStoreCreateSnapshotById-darwin.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/darwin/RTCrStoreCreateSnapshotById-darwin.cpp

@@ -95 +95 @@
                                                int rc, PRTERRINFO pErrInfo)
 {
+    /** @todo The SecKeychainSearchCreateFromAttributes and
+     * SecKeychainSearchCopyNext APIs have been officially deprecated since 10.7
+     * according to the header files.  However, the perferred API,
+     * SecItemCopyMatching (and possibly SecTrustCopyAnchorCertificates) would
+     * require a larger rewrite here and that's just not worth it right now.  We can
+     * do that should these APIs be removed (unlikely given the amount of grep hits
+     * in the public 10.15.3 sources). */
+
     /*
      * Enumerate the certificates in the keychain.
      */
+    RT_GCC_NO_WARN_DEPRECATED_BEGIN
     SecKeychainSearchRef hSearch;
     OSStatus orc = SecKeychainSearchCreateFromAttributes(hKeychain, kSecCertificateItemClass, NULL, &hSearch);
@@ -149 +158 @@
         rc = RTErrInfoAddF(pErrInfo, -VERR_SEARCH_ERROR,
                            "  SecKeychainSearchCreateFromAttributes failed with %#x", orc);
+    RT_GCC_NO_WARN_DEPRECATED_END
     return rc;
 }