Changeset 85511 in vbox for trunk/src/VBox/HostDrivers/Support

Timestamp:

Jul 29, 2020 10:21:19 AM (4 years ago)

Author:

vboxsync

Message:

SUP,*: Some changes to the SUP_IOCTL_LDR_OPEN and SUP_IOCTL_LDR_LOAD interfaces adding memory protection regions for better W^{X compliance. Preps for linux 5.8 where we'll be using RTR0MemObjAllocPage rather than RTMemExecAlloc for images, switch from relocatable ELF files to shared objects. [build fix] bugref:9801}

File:

• trunk/src/VBox/HostDrivers/Support/SUPLibLdr.cpp (modified) (2 diffs)

trunk/src/VBox/HostDrivers/Support/SUPLibLdr.cpp

@@ -594 +594 @@
         return RTErrInfoSetF(pErrInfo, rc, "RTLdrEnumSegments #2 failed");
     }
-    SegArgs.uEndRva = cbImage;
+    SegArgs.uEndRva = (uint32_t)cbImage;
+    AssertReturn(SegArgs.uEndRva == cbImage, VERR_OUT_OF_RANGE);
     if (SegArgs.uEndRva > SegArgs.uStartRva)
     {
@@ -759 +760 @@
         {
             Assert(SegArgs.uEndRva <= RTLdrSize(hLdrMod));
-            SegArgs.uEndRva = RTLdrSize(hLdrMod);
+            SegArgs.uEndRva = (uint32_t)CalcArgs.cbImage; /* overflow is checked later */
             if (SegArgs.uEndRva > SegArgs.uStartRva)
                 SegArgs.iSegs++;